You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2025/07/22 10:49:23 UTC
[PR] Avoid potential deadlock in TableFunctionLeafOperator [iotdb]
JackieTien97 opened a new pull request, #16002:
URL: https://github.com/apache/iotdb/pull/16002
This pull request introduces changes to improve the lifecycle management and concurrency handling of the `TableFunctionLeafOperator` class in the IoTDB query engine. The primary updates involve ensuring proper initialization of the processor and adding support for non-blocking operations.
### Enhancements to lifecycle management:
- **Initialization flag and deferred processor start**: Added a `volatile boolean init` field to track whether the processor has been initialized. The `processor.beforeStart()` method is now invoked during the `isBlocked()` method instead of the constructor, ensuring deferred initialization.
### Support for non-blocking operations:
- **`isBlocked` method implementation**: Introduced the `isBlocked()` method, returning a `ListenableFuture` to indicate non-blocked status. This aligns with the operator's lifecycle and concurrency requirements.
### Dependency update:
- **Added `ListenableFuture` import**: Imported `ListenableFuture` from Guava to support the non-blocking behavior in the `isBlocked()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid potential deadlock in TableFunctionLeafOperator [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16002:
URL: https://github.com/apache/iotdb/pull/16002#issuecomment-3102222277
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16002) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16002&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16002&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16002&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16002&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16002&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16002)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid potential deadlock in TableFunctionLeafOperator [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16002:
URL: https://github.com/apache/iotdb/pull/16002#issuecomment-3102369648
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/16002?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review.
> Project coverage is 39.03%. Comparing base [(`4f9e75f`)](https://app.codecov.io/gh/apache/iotdb/commit/4f9e75f944f0d3ac3250be3e3076cadcfd23d087?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f06a870`)](https://app.codecov.io/gh/apache/iotdb/commit/f06a870ea923bd0ee9eac007977a9c48b619f34d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/16002?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...or/process/function/TableFunctionLeafOperator.java](https://app.codecov.io/gh/apache/iotdb/pull/16002?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fexecution%2Foperator%2Fprocess%2Ffunction%2FTableFunctionLeafOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL29wZXJhdG9yL3Byb2Nlc3MvZnVuY3Rpb24vVGFibGVGdW5jdGlvbkxlYWZPcGVyYXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/16002?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16002 +/- ##
============================================
+ Coverage 39.01% 39.03% +0.01%
Complexity 198 198
============================================
Files 4848 4848
Lines 316025 316029 +4
Branches 39792 39792
============================================
+ Hits 123297 123349 +52
+ Misses 192728 192680 -48
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/16002?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid potential deadlock in TableFunctionLeafOperator [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #16002:
URL: https://github.com/apache/iotdb/pull/16002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org