You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/06 05:37:52 UTC
Review Request 69904: Extracted common offer matching functions from
SLRP tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9544
https://issues.apache.org/jira/browse/MESOS-9544
Repository: mesos
Description
-------
This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
`isPreprovisionedVolume` from all tests and makes them common utitily
functions in the test fixture.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377
Diff: https://reviews.apache.org/r/69904/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69904: Extracted common offer matching functions
from SLRP tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Feb. 12, 2019, 3:16 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 334 (patched)
> > <https://reviews.apache.org/r/69904/diff/2/?file=2124912#file2124912line334>
> >
> > Could you briefly document what these do?
> >
> > We could just declare these outside of the class in this file instead of them being `static`.
>
> Chun-Hung Hsiao wrote:
> Don't we usually put utilities in the test fixture?
Hmm yeah I see some local helpers declared as static global functions. Done.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/#review212744
-----------------------------------------------------------
On Feb. 12, 2019, 5:26 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69904/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 5:26 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9565
> https://issues.apache.org/jira/browse/MESOS-9565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
> `isPreprovisionedVolume` from all tests and makes them common utitily
> functions in the test fixture.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69904/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69904: Extracted common offer matching functions
from SLRP tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Feb. 12, 2019, 3:16 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 334 (patched)
> > <https://reviews.apache.org/r/69904/diff/2/?file=2124912#file2124912line334>
> >
> > Could you briefly document what these do?
> >
> > We could just declare these outside of the class in this file instead of them being `static`.
Don't we usually put utilities in the test fixture?
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/#review212744
-----------------------------------------------------------
On Feb. 12, 2019, 5:26 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69904/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 5:26 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9544
> https://issues.apache.org/jira/browse/MESOS-9544
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
> `isPreprovisionedVolume` from all tests and makes them common utitily
> functions in the test fixture.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69904/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69904: Extracted common offer matching functions
from SLRP tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/#review212744
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/storage_local_resource_provider_tests.cpp
Lines 334 (patched)
<https://reviews.apache.org/r/69904/#comment298642>
Could you briefly document what these do?
We could just declare these outside of the class in this file instead of them being `static`.
- Benjamin Bannier
On Feb. 12, 2019, 6:26 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69904/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 6:26 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9544
> https://issues.apache.org/jira/browse/MESOS-9544
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
> `isPreprovisionedVolume` from all tests and makes them common utitily
> functions in the test fixture.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69904/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69904: Extracted common offer matching functions
from SLRP tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/
-----------------------------------------------------------
(Updated Feb. 28, 2019, 12:23 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Rebased.
Bugs: MESOS-9565
https://issues.apache.org/jira/browse/MESOS-9565
Repository: mesos
Description
-------
This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
`isPreprovisionedVolume` from all tests and makes them common utitily
functions in the test fixture.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941
Diff: https://reviews.apache.org/r/69904/diff/4/
Changes: https://reviews.apache.org/r/69904/diff/3-4/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69904: Extracted common offer matching functions
from SLRP tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/
-----------------------------------------------------------
(Updated Feb. 13, 2019, 9:26 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed Benjamin's comment.
Bugs: MESOS-9565
https://issues.apache.org/jira/browse/MESOS-9565
Repository: mesos
Description
-------
This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
`isPreprovisionedVolume` from all tests and makes them common utitily
functions in the test fixture.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
Diff: https://reviews.apache.org/r/69904/diff/3/
Changes: https://reviews.apache.org/r/69904/diff/2-3/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69904: Extracted common offer matching functions
from SLRP tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/
-----------------------------------------------------------
(Updated Feb. 12, 2019, 5:26 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Rebased.
Bugs: MESOS-9544
https://issues.apache.org/jira/browse/MESOS-9544
Repository: mesos
Description
-------
This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
`isPreprovisionedVolume` from all tests and makes them common utitily
functions in the test fixture.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
Diff: https://reviews.apache.org/r/69904/diff/2/
Changes: https://reviews.apache.org/r/69904/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao