[GitHub] [beam] alexeyinkin commented on a diff in pull request #24457: [ToB] [Frontend] Authentication, unit progress, complete unit, SDK selection

[GitBox <gi...@apache.org>]

alexeyinkin commented on code in PR #24457:
URL: https://github.com/apache/beam/pull/24457#discussion_r1063128415


##########
learning/tour-of-beam/frontend/README.md:
##########
@@ -17,47 +17,62 @@
      under the License.
  -->
 
- # Tour of Beam
- These are the main sources of the Tour of Beam website.
+# Tour of Beam
 
- # About
+These are the main sources of the Tour of Beam website.
+
+# About
 
 ## Getting started
+
 Running, debugging, and testing all require this first step that fetches
 dependencies and generates code:
 
 ```bash
 cd ../../../playground/frontend/playground_components
 flutter pub get
-flutter pub run build_runner build
 cd ../../../learning/tour-of-beam/frontend
 flutter pub get
-flutter pub run build_runner build

Review Comment:
   Revert? Looks like it is needed.



##########
learning/tour-of-beam/frontend/README.md:
##########
@@ -17,47 +17,62 @@
      under the License.
  -->
 
- # Tour of Beam
- These are the main sources of the Tour of Beam website.
+# Tour of Beam
 
- # About
+These are the main sources of the Tour of Beam website.
+
+# About
 
 ## Getting started
+
 Running, debugging, and testing all require this first step that fetches
 dependencies and generates code:
 
 ```bash
 cd ../../../playground/frontend/playground_components
 flutter pub get
-flutter pub run build_runner build

Review Comment:
   Will this work instead of these 3 lines?
   ```bash
   ./gradlew :playground:frontend:generateCode
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org