You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/10/02 14:11:23 UTC

Review Request 62724: RANGER-1822 - Remove ssoEnabled accessors in RangerSSOAuthenticationFilter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62724/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1822
    https://issues.apache.org/jira/browse/RANGER-1822


Repository: ranger


Description
-------

This task is to remove the ssoEnabled accessors in RangerSSOAuthenticationFilter. "ssoEnabled" is currently a class variable, but it is overridden every time in the doFilter method. It should instead just be created per-request in doFilter.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 481fe8e7 


Diff: https://reviews.apache.org/r/62724/diff/1/


Testing
-------

Tested with Knox.


Thanks,

Colm O hEigeartaigh

Re: Review Request 62724: RANGER-1822 - Remove ssoEnabled accessors in RangerSSOAuthenticationFilter

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62724/#review187613
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 2, 2017, 2:11 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62724/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 2:11 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1822
>     https://issues.apache.org/jira/browse/RANGER-1822
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to remove the ssoEnabled accessors in RangerSSOAuthenticationFilter. "ssoEnabled" is currently a class variable, but it is overridden every time in the doFilter method. It should instead just be created per-request in doFilter.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 481fe8e7 
> 
> 
> Diff: https://reviews.apache.org/r/62724/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with Knox.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 62724: RANGER-1822 - Remove ssoEnabled accessors in RangerSSOAuthenticationFilter

Posted by Colm O hEigeartaigh <co...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62724/#review187505
-----------------------------------------------------------



Requesting review please, as it's blocking other patches.

- Colm O hEigeartaigh


On Oct. 2, 2017, 2:11 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62724/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 2:11 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1822
>     https://issues.apache.org/jira/browse/RANGER-1822
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to remove the ssoEnabled accessors in RangerSSOAuthenticationFilter. "ssoEnabled" is currently a class variable, but it is overridden every time in the doFilter method. It should instead just be created per-request in doFilter.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 481fe8e7 
> 
> 
> Diff: https://reviews.apache.org/r/62724/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with Knox.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 62724: RANGER-1822 - Remove ssoEnabled accessors in RangerSSOAuthenticationFilter

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62724/#review187609
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 2, 2017, 2:11 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62724/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 2:11 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1822
>     https://issues.apache.org/jira/browse/RANGER-1822
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to remove the ssoEnabled accessors in RangerSSOAuthenticationFilter. "ssoEnabled" is currently a class variable, but it is overridden every time in the doFilter method. It should instead just be created per-request in doFilter.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 481fe8e7 
> 
> 
> Diff: https://reviews.apache.org/r/62724/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with Knox.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 62724: RANGER-1822 - Remove ssoEnabled accessors in RangerSSOAuthenticationFilter

Posted by Zsombor Gegesy <gz...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62724/#review187513
-----------------------------------------------------------


Ship it!




I'm not a commiter, but it seems a good bug fix

- Zsombor Gegesy


On Oct. 2, 2017, 2:11 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62724/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 2:11 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1822
>     https://issues.apache.org/jira/browse/RANGER-1822
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to remove the ssoEnabled accessors in RangerSSOAuthenticationFilter. "ssoEnabled" is currently a class variable, but it is overridden every time in the doFilter method. It should instead just be created per-request in doFilter.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 481fe8e7 
> 
> 
> Diff: https://reviews.apache.org/r/62724/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with Knox.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>