You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/29 03:19:34 UTC
[PR] Refactor MCP E2E test suite naming [shardingsphere]
terrymanu opened a new pull request, #39264:
URL: https://github.com/apache/shardingsphere/pull/39264
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor MCP E2E test suite naming [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39264:
URL: https://github.com/apache/shardingsphere/pull/39264#issuecomment-5112456686
### Summary
**Review Result: Mergeable**
Reason: The latest patch consistently renames the MCP E2E suites, updates Maven/workflow selectors, and preserves behavior. This is a code-scope result only; CI was not reviewed by request.
### Evidence
- All 24 GitHub-listed files were reviewed.
- Renamed classes, packages, profile IDs, workflow selectors, and documentation are consistent.
- `test-compile` passed.
- `MCPClientTransportFactoryTest` passed: 2 tests, 0 failures.
### Review Details
- Review Focus: Code Correctness Review; CI not reviewed by request.
- Reviewed Scope: MCP workflow, Maven profile, English/Chinese test documentation, and all renamed MCP E2E tests. Head: `f63df077fcc8d77058c87286f14365fc36f2f24`; base/merge-base: `cfc9e2425f310af42c29d052d44be4c515947865`. Local file list matched GitHub.
- Not Reviewed Scope: GitHub Actions execution and CI logs.
- Verification:
- `./mvnw -pl test/e2e/mcp -Pe2e.mcp.functionality -DskipTests ... test-compile` — exit 0.
- `./mvnw -pl test/e2e/mcp -Pe2e.mcp.functionality -Dtest=MCPClientTransportFactoryTest ... test` — exit 0.
- Release Note / User Docs: User documentation updated; release notes are not required for this test-suite naming refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor MCP E2E test suite naming [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39264:
URL: https://github.com/apache/shardingsphere/pull/39264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org