You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/02 18:58:03 UTC
[GitHub] [kafka] pdruley opened a new pull request #11163: MINOR: doc change for minisr to clarify replicas in Kafka Config
pdruley opened a new pull request #11163:
URL: https://github.com/apache/kafka/pull/11163
This is a minor doc change to MinInSyncReplicasDoc to clarify what is a replica and further help users understand the importance of this configuration in relation to their producer configuration.
It didn't seem like a Jira was necessary but I am open to creating one if needed. I did not compile from source to test, no other code was changed.
This contribution is my original work and I license the work to the project under the project's open source license.
Thanks!
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] joel-hamill commented on pull request #11163: MINOR: doc change for minisr to clarify replicas in Kafka Config
Posted by GitBox <gi...@apache.org>.
joel-hamill commented on pull request #11163:
URL: https://github.com/apache/kafka/pull/11163#issuecomment-892895687
LGTM, had one comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] joel-hamill commented on a change in pull request #11163: MINOR: doc change for minisr to clarify replicas in Kafka Config
Posted by GitBox <gi...@apache.org>.
joel-hamill commented on a change in pull request #11163:
URL: https://github.com/apache/kafka/pull/11163#discussion_r682878756
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -826,10 +826,11 @@ object KafkaConfig {
"a write for the write to be considered successful. If this minimum cannot be met, " +
"then the producer will raise an exception (either NotEnoughReplicas or " +
"NotEnoughReplicasAfterAppend).<br>When used together, min.insync.replicas and acks " +
- "allow you to enforce greater durability guarantees. A typical scenario would be to " +
+ "allow you to enforce greater durability guarantees. The leader and its followers are " +
+ "all considered replicas so a typical scenario would be to " +
"create a topic with a replication factor of 3, set min.insync.replicas to 2, and " +
"produce with acks of \"all\". This will ensure that the producer raises an exception " +
- "if a majority of replicas do not receive a write."
+ "if a majority of replicas (2) do not receive a write."
Review comment:
```suggestion
"if a majority of replicas, in this case 2, do not receive a write."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] joel-hamill commented on a change in pull request #11163: MINOR: doc change for minisr to clarify replicas in Kafka Config
Posted by GitBox <gi...@apache.org>.
joel-hamill commented on a change in pull request #11163:
URL: https://github.com/apache/kafka/pull/11163#discussion_r682878756
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -826,10 +826,11 @@ object KafkaConfig {
"a write for the write to be considered successful. If this minimum cannot be met, " +
"then the producer will raise an exception (either NotEnoughReplicas or " +
"NotEnoughReplicasAfterAppend).<br>When used together, min.insync.replicas and acks " +
- "allow you to enforce greater durability guarantees. A typical scenario would be to " +
+ "allow you to enforce greater durability guarantees. The leader and its followers are " +
+ "all considered replicas so a typical scenario would be to " +
"create a topic with a replication factor of 3, set min.insync.replicas to 2, and " +
"produce with acks of \"all\". This will ensure that the producer raises an exception " +
- "if a majority of replicas do not receive a write."
+ "if a majority of replicas (2) do not receive a write."
Review comment:
```suggestion
"if a majority of replicas, in this case 2, do not receive a write."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] joel-hamill commented on pull request #11163: MINOR: doc change for minisr to clarify replicas in Kafka Config
Posted by GitBox <gi...@apache.org>.
joel-hamill commented on pull request #11163:
URL: https://github.com/apache/kafka/pull/11163#issuecomment-892895687
LGTM, had one comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org