[GitHub] [nuttx] pussuw commented on a diff in pull request #8206: libc: Implement quick_exit and at_quick_exit

["pussuw (via GitHub)" <gi...@apache.org>]

pussuw commented on code in PR #8206:
URL: https://github.com/apache/nuttx/pull/8206#discussion_r1084877025


##########
libs/libc/stdlib/lib_exit.c:
##########
@@ -46,22 +46,33 @@ FAR void *__dso_handle = &__dso_handle;
  * Public Functions
  ****************************************************************************/
 
-void exit(int status)
+void _Exit(int status)

Review Comment:
   I think flushing the streams here is not correct:
   
   The _Exit() and _exit() functions shall not call functions registered with atexit() nor any registered signal handlers. Open streams shall not be flushed.  Whether open streams are closed (without flushing) is implementation-defined. Finally, the calling process shall be terminated with the consequences described below.
   
   https://pubs.opengroup.org/onlinepubs/9699919799/functions/_Exit.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org