You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/07/01 05:54:16 UTC
[GitHub] [cassandra] bereng opened a new pull request #1094: Flaky ViewTest
bereng opened a new pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094#issuecomment-872739041
- CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/373/workflows/28ef0ce6-a9a0-49b4-a076-a28b891da053)
- CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/373/workflows/8e2b147d-96a4-4cc6-aa2d-5c0d7b18e564)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094#issuecomment-873889869
Squashed
- CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/375/workflows/67f3799a-b46f-46da-b199-8111c0fef889)
- CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/375/workflows/3d0a00b7-4a8e-4784-922f-bc219dfebf76)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on a change in pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng commented on a change in pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094#discussion_r663683879
##########
File path: test/unit/org/apache/cassandra/cql3/ViewTestAbstract.java
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.BeforeClass;
+
+import com.datastax.driver.core.exceptions.OperationTimedOutException;
+import org.apache.cassandra.concurrent.Stage;
+import org.awaitility.Awaitility;
+
+public abstract class ViewTestAbstract extends CQLTester
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng closed pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng closed pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng closed pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng closed pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] adelapena commented on a change in pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094#discussion_r662888589
##########
File path: test/unit/org/apache/cassandra/cql3/ViewTestAbstract.java
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.BeforeClass;
+
+import com.datastax.driver.core.exceptions.OperationTimedOutException;
+import org.apache.cassandra.concurrent.Stage;
+import org.awaitility.Awaitility;
+
+public abstract class ViewTestAbstract extends CQLTester
Review comment:
Maybe we can mark this class with `@Ignore` instead of relying on the name pattern, like we do in `AbstractTransactionalTest`, `AbstractRepairTest`, `AbstractReadResponseTest`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094#issuecomment-872094765
- CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra?branch=CASSANDRA-16777-4.0.0)
- CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/371/workflows/e283e3ac-8dda-4c22-9fb4-f81cdbb8d627)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng edited a comment on pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng edited a comment on pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094#issuecomment-872739041
- CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/373/workflows/28ef0ce6-a9a0-49b4-a076-a28b891da053) unrelated failure
- CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/373/workflows/8e2b147d-96a4-4cc6-aa2d-5c0d7b18e564)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094#issuecomment-873855960
- CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/374/workflows/7cf8ed01-d98f-49a6-a3e5-0b5e10dfa45b)
- CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/374/workflows/2aa1a471-54fe-4955-8355-ef70ed7fa71e)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #1094: Flaky ViewTest
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #1094:
URL: https://github.com/apache/cassandra/pull/1094#issuecomment-873889869
Squashed
- CI [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/375/workflows/67f3799a-b46f-46da-b199-8111c0fef889)
- CI [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/375/workflows/3d0a00b7-4a8e-4784-922f-bc219dfebf76)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org