You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/27 10:29:56 UTC

[GitHub] [pulsar] lhotari commented on pull request #11815: fix flaky test testReacquireLocksAfterSessionLost

lhotari commented on pull request #11815:
URL: https://github.com/apache/pulsar/pull/11815#issuecomment-907101064


   why does this fix the issue? 
   
   The reason I'm asking is that it should be possible that  `assertFalse(lock.getLockExpiredFuture().isDone())` becomes `false` after it has become `true`.  `lock.getLockExpiredFuture()` is a CompletableFuture and the reference doesn't get switched at any point in the test. If the CompletableFuture is done, it will never become undone.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org