You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "leaves12138 (via GitHub)" <gi...@apache.org> on 2025/10/29 06:46:40 UTC
[PR] [core] Fix data-evolution row count should be more accurate. [paimon]
leaves12138 opened a new pull request, #6489:
URL: https://github.com/apache/paimon/pull/6489
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Data evolution table total records in snapshot should be more accurate
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Fix data-evolution row count should be more accurate. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #6489:
URL: https://github.com/apache/paimon/pull/6489#issuecomment-3466811696
Should we also modify split row count just like python?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Fix data-evolution row count should be more accurate. [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #6489:
URL: https://github.com/apache/paimon/pull/6489#issuecomment-3471067192
> Should we also modify split row count just like python?
Sure~ Fixed as requested~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Fix data-evolution row count should be more accurate. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6489:
URL: https://github.com/apache/paimon/pull/6489#discussion_r2476205042
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1120,8 +1123,16 @@ CommitResult tryCommitOnce(
}
// the added records subtract the deleted records from
- long deltaRecordCount = recordCountAdd(deltaFiles) - recordCountDelete(deltaFiles);
- long totalRecordCount = previousTotalRecordCount + deltaRecordCount;
+ long deltaRecordCount;
+ long totalRecordCount;
+
+ if (dataEvolutionEnabled) {
+ deltaRecordCount = nextRowIdStart - firstRowIdStart;
+ totalRecordCount = nextRowIdStart;
+ } else {
+ deltaRecordCount = recordCountAdd(deltaFiles) - recordCountDelete(deltaFiles);
Review Comment:
I think we don't need to modify here, we should also modify split row count just like python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Fix data-evolution row count should be more accurate. [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 closed pull request #6489: [core] Fix data-evolution row count should be more accurate.
URL: https://github.com/apache/paimon/pull/6489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Fix data-evolution row count should be more accurate. [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #6489:
URL: https://github.com/apache/paimon/pull/6489#issuecomment-3670246299
Close this for now, maybe open it in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Fix data-evolution row count should be more accurate. [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on code in PR #6489:
URL: https://github.com/apache/paimon/pull/6489#discussion_r2476228768
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1120,8 +1123,16 @@ CommitResult tryCommitOnce(
}
// the added records subtract the deleted records from
- long deltaRecordCount = recordCountAdd(deltaFiles) - recordCountDelete(deltaFiles);
- long totalRecordCount = previousTotalRecordCount + deltaRecordCount;
+ long deltaRecordCount;
+ long totalRecordCount;
+
+ if (dataEvolutionEnabled) {
+ deltaRecordCount = nextRowIdStart - firstRowIdStart;
+ totalRecordCount = nextRowIdStart;
+ } else {
+ deltaRecordCount = recordCountAdd(deltaFiles) - recordCountDelete(deltaFiles);
Review Comment:
Maybe we can modify here too, it depends on how it defines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org