You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by ma...@apache.org on 2021/04/11 02:42:37 UTC

[apisix-dashboard] branch master updated: fix: remove proxy-rewrite plugin out of create plugin template config view (#1723)

This is an automated email from the ASF dual-hosted git repository.

majunjie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
     new 990662a  fix: remove proxy-rewrite plugin out of create plugin template config view (#1723)
990662a is described below

commit 990662a8b2b16bafb11f4c48d243ae72abead0d1
Author: liuxiran <li...@apache.org>
AuthorDate: Sun Apr 11 10:42:30 2021 +0800

    fix: remove proxy-rewrite plugin out of create plugin template config view (#1723)
    
    Co-authored-by: 琚致远 <ju...@apache.org>
---
 .../pluginTemplate/create-edit-delete-plugin-template.spec.js      | 4 ++++
 web/src/pages/PluginTemplate/Create.tsx                            | 7 ++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js b/web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
index 5f8186e..ea0a4dd 100644
--- a/web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
+++ b/web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
@@ -36,6 +36,10 @@ context('Create Configure and Delete PluginTemplate', () => {
 
     cy.get(this.domSelector.description).type(this.data.pluginTemplateName);
     cy.contains('Next').click();
+
+    // should not see proxy-rewrite plugin in the step2
+    cy.contains('proxy-rewrite').should('not.exist');
+
     cy.contains('Enable').click({
       force: true
     });
diff --git a/web/src/pages/PluginTemplate/Create.tsx b/web/src/pages/PluginTemplate/Create.tsx
index 3da8cb1..8bf3824 100644
--- a/web/src/pages/PluginTemplate/Create.tsx
+++ b/web/src/pages/PluginTemplate/Create.tsx
@@ -108,7 +108,12 @@ const Page: React.FC = (props) => {
 
           {step === 1 && <Step1 form={form1} />}
           {step === 2 && (
-            <PluginPage initialData={plugins} onChange={setPlugins} schemaType="route" />
+            <PluginPage
+              initialData={plugins}
+              onChange={setPlugins}
+              referPage="route"
+              schemaType="route"
+             />
           )}
           {step === 3 && <Preview form1={form1} plugins={plugins} />}
         </Card>