You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/17 00:44:05 UTC
[jira] [Commented] (STORM-1911) Inconsistency of timestamp between
IMetricsConsumer and IClusterMetricsConsumer
[ https://issues.apache.org/jira/browse/STORM-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335101#comment-15335101 ]
ASF GitHub Bot commented on STORM-1911:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1498
STORM-1911 IClusterMetricsConsumer should use seconds to timestamp unit
* to have consistency with IMetricsConsumer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1911
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1498.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1498
----
commit f05114a0d127d51aae55fd844dc048e1aca2efc4
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-06-17T00:40:17Z
STORM-1911 IClusterMetricsConsumer should use seconds to timestamp unit
* to have consistency with IMetricsConsumer
----
> Inconsistency of timestamp between IMetricsConsumer and IClusterMetricsConsumer
> -------------------------------------------------------------------------------
>
> Key: STORM-1911
> URL: https://issues.apache.org/jira/browse/STORM-1911
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> There's inconsistency of timestamp between IMetricsConsumer and IClusterMetricsConsumer: former is seconds and latter is milliseconds.
> Since both of two are representing it to timestamp, and IMetricsConsumer is already being used, we need to change timestamp of IClusterMetricsConsumer to seconds.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)