You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2014/02/19 00:39:20 UTC

[jira] [Commented] (HBASE-9383) Have Cell interface extend HeapSize interface

    [ https://issues.apache.org/jira/browse/HBASE-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904809#comment-13904809 ] 

Enis Soztutar commented on HBASE-9383:
--------------------------------------

Agreed with Stack's comments on  HBASE-7320. I don't think HeapSize belongs to the Cell interface. Maybe we can have a CellContainer interface, where CellContainer, and KV and encoders implement CellContainer. Also, since Cell is a public facing API, I think we have to be careful to not include methods. We actually want to hide the internal methods in Cell. 

> Have Cell interface extend HeapSize interface
> ---------------------------------------------
>
>                 Key: HBASE-9383
>                 URL: https://issues.apache.org/jira/browse/HBASE-9383
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.96.0
>            Reporter: Jonathan Hsieh
>
> From the review of HBASE-9359. 
> bq. Stack: Cell should implement HeapSize?  That sounds right.
> bq. Ram: +1 for Cell extending HeapSize.
> bq. Jon: I'll look into Cell extending HeapSize as a follow on.  It doesn't interfere with the signature and if a older 0.96 client talks to a 0.96.1 rs that has the change, it won't matter.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)