You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/08 17:05:49 UTC

[GitHub] [iceberg] danielcweeks commented on pull request #1166: Apply table import test suites to Spark 3

danielcweeks commented on pull request #1166:
URL: https://github.com/apache/iceberg/pull/1166#issuecomment-655642873


   This look fine to me, but I'm not clear on why we couldn't just create test suite that references the original tests in the spark module as opposed to subclassing new tests in the 2/3 specific modules.
   
   I'm fine with this though. +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org