[GitHub] [calcite-avatica] ambition119 commented on issue #96: support from unix timestamp to string date

[GitBox <gi...@apache.org>]

ambition119 commented on issue #96: support from unix timestamp to string date
URL: https://github.com/apache/calcite-avatica/pull/96#issuecomment-489890614
 
 
   > There are uses of default locale here. We can't have that. This code needs to behave identically in all locales.
   > 
   > In one or two places the comment says "unsigned int" when the result is clearly a signed long.
   > 
   > Methods that have a timezone argument must state very clearly, with examples, how the timezone is used. Are you converting to that timezone or from that timezone? So many times I expect a method to add 8 hours (to pacific) and it ends up subtracting 8 hours.
   
   Thank you for your suggestion, I will try to fix the problem caused by timezone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services