You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Lai <ja...@jasonlai.net> on 2018/09/25 00:05:45 UTC
Review Request 68832: Add unit tests for Stout `path::normalize`
function in POSIX.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Add unit tests for Stout `path::normalize` function in POSIX.
Diffs
-----
3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
Diff: https://reviews.apache.org/r/68832/diff/1/
Testing
-------
`make tests`
Thanks,
Jason Lai
Re: Review Request 68832: Add unit tests for Stout `path::normalize`
function in POSIX.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/#review210397
-----------------------------------------------------------
PASS: Mesos patch 68832 was successfully built and tested.
Reviews applied: `['65811', '68832']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2580/mesos-review-68832
- Mesos Reviewbot Windows
On Nov. 7, 2018, 10:29 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68832/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2018, 10:29 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257 and MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-9009
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add unit tests for Stout `path::normalize` function in POSIX.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
>
>
> Diff: https://reviews.apache.org/r/68832/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 68832: Add unit tests for Stout `path::normalize`
function in POSIX.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/#review210639
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 7, 2018, 10:29 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68832/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2018, 10:29 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257 and MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-9009
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add unit tests for Stout `path::normalize` function in POSIX.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
>
>
> Diff: https://reviews.apache.org/r/68832/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 68832: Add unit tests for Stout `path::normalize`
function in POSIX.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/
-----------------------------------------------------------
(Updated Nov. 7, 2018, 10:29 p.m.)
Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Rebranch the commit parent to #65811
Bugs: MESOS-8257 and MESOS-9009
https://issues.apache.org/jira/browse/MESOS-8257
https://issues.apache.org/jira/browse/MESOS-9009
Repository: mesos
Description
-------
Add unit tests for Stout `path::normalize` function in POSIX.
Diffs
-----
3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
Diff: https://reviews.apache.org/r/68832/diff/2/
Testing
-------
`make check`
Thanks,
Jason Lai
Re: Review Request 68832: Add unit tests for Stout `path::normalize`
function in POSIX.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/
-----------------------------------------------------------
(Updated Nov. 7, 2018, 10:10 p.m.)
Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Required for [MESOS-9009](https://issues.apache.org/jira/browse/MESOS-9009)
Bugs: MESOS-8257 and MESOS-9009
https://issues.apache.org/jira/browse/MESOS-8257
https://issues.apache.org/jira/browse/MESOS-9009
Repository: mesos
Description
-------
Add unit tests for Stout `path::normalize` function in POSIX.
Diffs
-----
3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
Diff: https://reviews.apache.org/r/68832/diff/2/
Testing
-------
`make check`
Thanks,
Jason Lai
Re: Review Request 68832: Add unit tests for Stout `path::normalize`
function in POSIX.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/
-----------------------------------------------------------
(Updated Nov. 7, 2018, 9:26 p.m.)
Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Rebased to master
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Add unit tests for Stout `path::normalize` function in POSIX.
Diffs (updated)
-----
3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
Diff: https://reviews.apache.org/r/68832/diff/2/
Changes: https://reviews.apache.org/r/68832/diff/1-2/
Testing (updated)
-------
`make check`
Thanks,
Jason Lai
Re: Review Request 68832: Add unit tests for Stout `path::normalize`
function in POSIX.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/#review208978
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Chung
On Sept. 25, 2018, 12:05 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68832/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2018, 12:05 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add unit tests for Stout `path::normalize` function in POSIX.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
>
>
> Diff: https://reviews.apache.org/r/68832/diff/1/
>
>
> Testing
> -------
>
> `make tests`
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 68832: Add unit tests for Stout `path::normalize`
function in POSIX.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/#review208980
-----------------------------------------------------------
PASS: Mesos patch 68832 was successfully built and tested.
Reviews applied: `['65811', '68832']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2392/mesos-review-68832
- Mesos Reviewbot Windows
On Sept. 25, 2018, 12:05 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68832/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2018, 12:05 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add unit tests for Stout `path::normalize` function in POSIX.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
>
>
> Diff: https://reviews.apache.org/r/68832/diff/1/
>
>
> Testing
> -------
>
> `make tests`
>
>
> Thanks,
>
> Jason Lai
>
>