You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tanruixiang (via GitHub)" <gi...@apache.org> on 2023/08/21 09:01:54 UTC

[GitHub] [arrow-datafusion] tanruixiang opened a new pull request, #7348: Implement `array_pop_back` function

tanruixiang opened a new pull request, #7348:
URL: https://github.com/apache/arrow-datafusion/pull/7348

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #6997 .
   
   ## Rationale for this change
   see #6997 
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   yes
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #7348: Implement `array_pop_back` function

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7348:
URL: https://github.com/apache/arrow-datafusion/pull/7348#issuecomment-1690281756

   Thanks @tanruixiang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #7348: Implement `array_pop_back` function

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7348:
URL: https://github.com/apache/arrow-datafusion/pull/7348


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #7348: Implement `array_pop_back` function

Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on code in PR #7348:
URL: https://github.com/apache/arrow-datafusion/pull/7348#discussion_r1300110602


##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -601,6 +601,22 @@ pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef> {
     define_array_slice(list_array, key, extra_key, false)
 }
 
+pub fn array_pop_back(args: &[ArrayRef]) -> Result<ArrayRef> {

Review Comment:
   @tanruixiang Do you want to implement `array_pop_front` function (See the ticket: https://github.com/apache/arrow-datafusion/issues/6996)? It has the similar syntax and it's a quite improvement your contribution in the project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tanruixiang commented on a diff in pull request #7348: Implement `array_pop_back` function

Posted by "tanruixiang (via GitHub)" <gi...@apache.org>.
tanruixiang commented on code in PR #7348:
URL: https://github.com/apache/arrow-datafusion/pull/7348#discussion_r1300158937


##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -601,6 +601,22 @@ pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef> {
     define_array_slice(list_array, key, extra_key, false)
 }
 
+pub fn array_pop_back(args: &[ArrayRef]) -> Result<ArrayRef> {

Review Comment:
   Yes, I would love to implement `array_pop_front `, do I need to implement `array_pop_front ` in this pr? Or in the next pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tanruixiang commented on pull request #7348: Implement `array_pop_back` function

Posted by "tanruixiang (via GitHub)" <gi...@apache.org>.
tanruixiang commented on PR #7348:
URL: https://github.com/apache/arrow-datafusion/pull/7348#issuecomment-1689486162

   @alamb @jayzhan211 @izveigor Thanks to all for the reviews, the conflict has been resolved!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jayzhan211 commented on a diff in pull request #7348: Implement `array_pop_back` function

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on code in PR #7348:
URL: https://github.com/apache/arrow-datafusion/pull/7348#discussion_r1300196280


##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -601,6 +601,22 @@ pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef> {
     define_array_slice(list_array, key, extra_key, false)
 }
 
+pub fn array_pop_back(args: &[ArrayRef]) -> Result<ArrayRef> {

Review Comment:
   Next pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tanruixiang commented on pull request #7348: Implement `array_pop_back` function

Posted by "tanruixiang (via GitHub)" <gi...@apache.org>.
tanruixiang commented on PR #7348:
URL: https://github.com/apache/arrow-datafusion/pull/7348#issuecomment-1685937551

   cc @izveigor  @jayzhan211 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org