You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/02/16 09:04:24 UTC

[GitHub] [spark] zhengruifeng commented on a diff in pull request #39985: [SPARK-42412][WIP] Initial prototype implementation of PySpark ML via Spark connect

zhengruifeng commented on code in PR #39985:
URL: https://github.com/apache/spark/pull/39985#discussion_r1108192576


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -76,6 +76,8 @@ message Relation {
     StatFreqItems freq_items = 106;
     StatSampleBy sample_by = 107;
 
+    int64 server_side_dataframe_id = 108;

Review Comment:
   what is the dataframe/logicalplan here? is it the output of model prediction (`model.transform`) ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org