You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "Jiri Peinlich (JIRA)" <ji...@apache.org> on 2012/11/14 14:22:13 UTC
[jira] [Created] (MTOMCAT-185) Possibly wrong execution phase in
tomcat7:run
Jiri Peinlich created MTOMCAT-185:
-------------------------------------
Summary: Possibly wrong execution phase in tomcat7:run
Key: MTOMCAT-185
URL: https://issues.apache.org/jira/browse/MTOMCAT-185
Project: Apache Tomcat Maven Plugin
Issue Type: Bug
Components: tomcat7
Affects Versions: 2.0
Reporter: Jiri Peinlich
Assignee: Olivier Lamy (*$^¨%`£)
Hello,
I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.
We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.
After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.
My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.
I checked the sources and to me it seams that the phase should be set here:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup
The execution phase is set there to be compile (curretnly line 60)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[jira] [Commented] (MTOMCAT-185) change phase for tomcat6/7:run to
process-classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497111#comment-13497111 ]
Hudson commented on MTOMCAT-185:
--------------------------------
Integrated in TomcatMavenPlugin-mvn3.x #219 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/219/])
[MTOMCAT-185] change phase for tomcat6/7:run to process-classes (Revision 1409194)
Result = SUCCESS
olamy : http://svn.apache.org/viewvc/?view=rev&rev=1409194
Files :
* /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
* /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
> change phase for tomcat6/7:run to process-classes
> -------------------------------------------------
>
> Key: MTOMCAT-185
> URL: https://issues.apache.org/jira/browse/MTOMCAT-185
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
> Affects Versions: 2.0
> Reporter: Jiri Peinlich
> Assignee: Olivier Lamy (*$^¨%`£)
> Labels: maven, newbie
> Fix For: 2.1
>
>
> Hello,
> I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.
> We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.
> After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.
> My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.
> I checked the sources and to me it seams that the phase should be set here:
> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup
> The execution phase is set there to be compile (curretnly line 60)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[jira] [Commented] (MTOMCAT-185) change phase for tomcat6/7:run to
process-classes
Posted by "Jiri Peinlich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497104#comment-13497104 ]
Jiri Peinlich commented on MTOMCAT-185:
---------------------------------------
Thank you :).
> change phase for tomcat6/7:run to process-classes
> -------------------------------------------------
>
> Key: MTOMCAT-185
> URL: https://issues.apache.org/jira/browse/MTOMCAT-185
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
> Affects Versions: 2.0
> Reporter: Jiri Peinlich
> Assignee: Olivier Lamy (*$^¨%`£)
> Labels: maven, newbie
> Fix For: 2.1
>
>
> Hello,
> I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.
> We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.
> After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.
> My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.
> I checked the sources and to me it seams that the phase should be set here:
> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup
> The execution phase is set there to be compile (curretnly line 60)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[jira] [Commented] (MTOMCAT-185) change phase for tomcat6/7:run to
process-classes
Posted by "Jiri Peinlich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497109#comment-13497109 ]
Jiri Peinlich commented on MTOMCAT-185:
---------------------------------------
I can confirm, that it is fixed in the snapshot. Thank you.
> change phase for tomcat6/7:run to process-classes
> -------------------------------------------------
>
> Key: MTOMCAT-185
> URL: https://issues.apache.org/jira/browse/MTOMCAT-185
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
> Affects Versions: 2.0
> Reporter: Jiri Peinlich
> Assignee: Olivier Lamy (*$^¨%`£)
> Labels: maven, newbie
> Fix For: 2.1
>
>
> Hello,
> I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.
> We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.
> After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.
> My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.
> I checked the sources and to me it seams that the phase should be set here:
> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup
> The execution phase is set there to be compile (curretnly line 60)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[jira] [Closed] (MTOMCAT-185) change phase for tomcat6/7:run to
process-classes
Posted by "Olivier Lamy (*$^¨%`£ JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy (*$^¨%`£) closed MTOMCAT-185.
------------------------------------------
Resolution: Fixed
Yup I agree it's a better phase especially for your use cad :-)
So I change that.
> change phase for tomcat6/7:run to process-classes
> -------------------------------------------------
>
> Key: MTOMCAT-185
> URL: https://issues.apache.org/jira/browse/MTOMCAT-185
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
> Affects Versions: 2.0
> Reporter: Jiri Peinlich
> Assignee: Olivier Lamy (*$^¨%`£)
> Labels: maven, newbie
> Fix For: 2.1
>
>
> Hello,
> I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.
> We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.
> After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.
> My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.
> I checked the sources and to me it seams that the phase should be set here:
> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup
> The execution phase is set there to be compile (curretnly line 60)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[jira] [Comment Edited] (MTOMCAT-185) change phase for
tomcat6/7:run to process-classes
Posted by "Olivier Lamy (*$^¨%`£ JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497100#comment-13497100 ]
Olivier Lamy (*$^¨%`£) edited comment on MTOMCAT-185 at 11/14/12 1:48 PM:
--------------------------------------------------------------------------
Yup I agree it's a better phase especially for your use case :-)
So I change that.
NOTE you can test snapshot following instructions from here: http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/snapshot-test.html
was (Author: olamy):
Yup I agree it's a better phase especially for your use cad :-)
So I change that.
> change phase for tomcat6/7:run to process-classes
> -------------------------------------------------
>
> Key: MTOMCAT-185
> URL: https://issues.apache.org/jira/browse/MTOMCAT-185
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
> Affects Versions: 2.0
> Reporter: Jiri Peinlich
> Assignee: Olivier Lamy (*$^¨%`£)
> Labels: maven, newbie
> Fix For: 2.1
>
>
> Hello,
> I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.
> We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.
> After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.
> My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.
> I checked the sources and to me it seams that the phase should be set here:
> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup
> The execution phase is set there to be compile (curretnly line 60)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[jira] [Reopened] (MTOMCAT-185) change phase for tomcat6/7:run to
process-classes
Posted by "Olivier Lamy (*$^¨%`£ JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy (*$^¨%`£) reopened MTOMCAT-185:
--------------------------------------------
> change phase for tomcat6/7:run to process-classes
> -------------------------------------------------
>
> Key: MTOMCAT-185
> URL: https://issues.apache.org/jira/browse/MTOMCAT-185
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
> Affects Versions: 2.0
> Reporter: Jiri Peinlich
> Assignee: Olivier Lamy (*$^¨%`£)
> Labels: maven, newbie
> Fix For: 2.1
>
>
> Hello,
> I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.
> We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.
> After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.
> My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.
> I checked the sources and to me it seams that the phase should be set here:
> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup
> The execution phase is set there to be compile (curretnly line 60)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[jira] [Updated] (MTOMCAT-185) change phase for tomcat6/7:run to
process-classes
Posted by "Olivier Lamy (*$^¨%`£ JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MTOMCAT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy (*$^¨%`£) updated MTOMCAT-185:
-------------------------------------------
Fix Version/s: 2.1
Summary: change phase for tomcat6/7:run to process-classes (was: Possibly wrong execution phase in tomcat7:run)
> change phase for tomcat6/7:run to process-classes
> -------------------------------------------------
>
> Key: MTOMCAT-185
> URL: https://issues.apache.org/jira/browse/MTOMCAT-185
> Project: Apache Tomcat Maven Plugin
> Issue Type: Bug
> Components: tomcat7
> Affects Versions: 2.0
> Reporter: Jiri Peinlich
> Assignee: Olivier Lamy (*$^¨%`£)
> Labels: maven, newbie
> Fix For: 2.1
>
>
> Hello,
> I do not know enough about maven+tomcat and related technologies to know if the following is bug, or if I just missed some setting somewhere.
> We have in our project dependencies, that inject some byte-code into compiled classes in the process-classes maven phase. I was trying to use maven tomcat7 plugin in version 2.0 to see how is our application working. When executing mvn tomcat7:run i run into problems because the maven phase process-classes was not executed before deploying on tomcat.
> After some research we found that there is plugin.xml file in the tomcat7 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plugin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run</goal> and in this mojo there i found <executePhase>compile</executePhase>. I think that the execution phase should be set to process-classes phase and not compile phase.
> My problems disappeared When I manually edited the xml and tried the mvn tomcat7:run afterwards. This makes me think that the phase is wrongly set in the jar.
> I checked the sources and to me it seams that the phase should be set here:
> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?view=markup
> The execution phase is set there to be compile (curretnly line 60)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org