[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #4761: [TE] Centralized cache proof-of-concept for anomaly detection via Couchbase

[GitBox <gi...@apache.org>]

vincentchenjl commented on a change in pull request #4761: [TE] Centralized cache proof-of-concept for anomaly detection via Couchbase
URL: https://github.com/apache/incubator-pinot/pull/4761#discussion_r341360549
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/cache/ThirdEyeCacheRequest.java
 ##########
 @@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.thirdeye.detection.cache;
+
+import org.apache.pinot.thirdeye.datasource.ThirdEyeRequest;
+import org.apache.pinot.thirdeye.rootcause.impl.MetricEntity;
+import org.apache.pinot.thirdeye.util.CacheUtils;
+
+
+public class ThirdEyeCacheRequest {
+  ThirdEyeRequest request;
+  private long metricId;
+  private String metricUrn;
+  private long startTimeInclusive;
+  private long endTimeExclusive;
+
+  public ThirdEyeCacheRequest(ThirdEyeRequest request, long metricId, String metricUrn, long startTimeInclusive, long endTimeExclusive) {
+    this.request = request;
+    this.metricId = metricId;
+    this.metricUrn = metricUrn;
+    this.startTimeInclusive = startTimeInclusive;
+    this.endTimeExclusive = endTimeExclusive;
+  }
+
+  public static ThirdEyeCacheRequest from(ThirdEyeRequest request) {
+
+    long metricId = request.getMetricFunctions().get(0).getMetricId();
+    String metricUrn = MetricEntity.fromMetric(request.getFilterSet().asMap(), metricId).getUrn();
+    long startTime = request.getStartTimeInclusive().getMillis();
+    long endTime = request.getEndTimeExclusive().getMillis();
+
+    return new ThirdEyeCacheRequest(request, metricId, metricUrn, startTime, endTime);
 
 Review comment:
   Maybe make this class as a total wrapper class, which does not have any member variable and implement the getters by using method of `ThirdEyeRequest`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org