You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/06/09 06:42:31 UTC
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #2748: Sql aggregator does not work in native mode.
JiriOndrusek commented on a change in pull request #2748:
URL: https://github.com/apache/camel-quarkus/pull/2748#discussion_r648010431
##########
File path: docs/modules/ROOT/pages/reference/extensions/sql.adoc
##########
@@ -67,6 +67,25 @@ Note that URI schemes such as `file` or `http` do not need to be listed.
quarkus.camel.sql.script-files = queries.sql, classpath:sql/insert.sql
----
+=== SQL Aggregator ===
+
+If your exchanges in native mode contain objects other than:
+
+* `java.util.LinkedHashMap`
+* `java.util.HashMap`
+* `java.lang.String`
+* `java.lang.Number`
+* `java.lang.Integer`
Review comment:
@ppalaga I used an approach, where I registered only the necessary objects to allow serialization of `DefaultExchangeHolder`. (SQL extension then adds String and Integer)
Another approach would be to register basic types for serialization dorectly in core (like boolean, float, double, biginteger, long, may be some others).
Surely the second approach would be much more pleasant for the users.
If you agree, I would register basic types in core and would make this list bigger.
From my POV it wold make sense to add it into some*.adoc here - near core - that these types are registered automatically and link these types from sql adoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org