You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/13 21:17:50 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #33672: [SPARK-35320][SQL] Align error message for unsupported key types in MapType in Json reader

MaxGekk commented on a change in pull request #33672:
URL: https://github.com/apache/spark/pull/33672#discussion_r688785369



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2943,6 +2943,33 @@ class DataFrameSuite extends QueryTest
       .withSequenceColumn("default_index").collect().map(_.getLong(0))
     assert(ids.toSet === Range(0, 10).toSet)
   }
+
+  test("SPARK-35320 Reading JSON with key type different to String in a map should fail") {

Review comment:
       The convention is `SPARK-35320:`. Please, look test titles around.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org