[jira] [Resolved] (YUNIKORN-3420) String() methods that take their own lock

["Dale Richardson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dale Richardson resolved YUNIKORN-3420.
---------------------------------------
    Resolution: Not A Problem

Closed as "Not A Problem" as call-site analysis has indicated that nothing in the code currently triggers the code path that could cause the deadlock

> String() methods that take their own lock
> -----------------------------------------
>
>                 Key: YUNIKORN-3420
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-3420
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: core - common, core - scheduler
>            Reporter: Dale Richardson
>            Assignee: jimmycmlin
>            Priority: Minor
>              Labels: pull-request-available
>
> {{TrackedResource.String}}, {{Queue.String}}, {{Allocation.String}} (through {{GetAllocatedResource}} / {{IsAllocated}}) and {{Application.String}} (through {{GetSubmissionTime}}) take the read lock of the object they print. {{fmt}} and {{zap}} evaluate a {{Stringer}} whenever the log line is built, which the type does not control; if that happens while the caller holds the object's write lock, the goroutine deadlocks on itself.
> No such caller was found in the current tree, so this is a trap rather than a bug that fires today. It is filed because a log line added under the write lock in future would hang silently, and because the fix is small.
> Fix: print only fields fixed at construction, or have the caller take a snapshot under the lock and print that. Note that {{Application}}'s submission time is not construction-fixed (it is reassigned on the recovery and placeholder paths), so it needs the snapshot treatment rather than a direct read.
> Marker: four {{+lockstringerignore}} sites carry this JIRA; the fix removes them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org