[jira] [Comment Edited] (CASSANDRA-6380) SSTableReader.loadSummary may leave an open file

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827636#comment-13827636 ] 

Jonathan Ellis edited comment on CASSANDRA-6380 at 11/20/13 1:27 PM:
---------------------------------------------------------------------

LGTM; committed

(Didn't see Yuki's comment.  The problem is that the catch block runs before the finally, so it tries to delete before the close, which works on linux but not windows.)


was (Author: jbellis):
LGTM; committed

> SSTableReader.loadSummary may leave an open file
> ------------------------------------------------
>
>                 Key: CASSANDRA-6380
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6380
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Mikhail Stepura
>            Assignee: Mikhail Stepura
>            Priority: Minor
>             Fix For: 2.0.3
>
>         Attachments: CASSANDRA-2.0-6380.patch
>
>
> When {{SSTableReader.loadSummary}} catches _IOException_ it tries to delete {{summariesFile}}, but the {{iStream}} is still open and the file is locked, so {{FileUtils.deleteWithConfirm}} fails, at least on Windows



--
This message was sent by Atlassian JIRA
(v6.1#6144)