You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/09/22 00:55:16 UTC

[I] [Bug] Switching the display language resets an unsaved NameServer selection on the Ops page [rocketmq-dashboard]

Frun1na opened a new issue, #4819:
URL: https://github.com/apache/rocketmq-dashboard/issues/4819

   ### Before Creating the Bug Report
   
   - [x] I have searched the [open issues](https://github.com/apache/rocketmq-dashboard/issues) and found no similar issue.
   
   ### What Happened
   
   On the Ops configuration page, an operator who selects a NameServer from the list (not yet saved)
   loses that selection by switching the display language in the top bar: the select silently snaps back
   to the stored current NameServer.
   
   The page's load effect depends on `fetchFailedMessage`, a string derived from `t('ops.fetchFailed')`,
   so a language change re-runs it — and the re-run ends with an unconditional
   `setSelectedNamesrv(data.currentNamesrv)`. This is the same root cause #4590 fixed for the instance
   selection in `BrokerCluster.tsx`; `Ops.tsx` still had the unguarded setter.
   
   ### Expected Behavior
   
   An unsaved selection that still appears in the freshly loaded NameServer list should survive the
   language change; only a selection that no longer exists falls back to the stored current NameServer.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] Switching the display language resets an unsaved NameServer selection on the Ops page [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.

lizhimins closed issue #4819: [Bug] Switching the display language resets an unsaved NameServer selection on the Ops page
URL: https://github.com/apache/rocketmq-dashboard/issues/4819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] Switching the display language resets an unsaved NameServer selection on the Ops page [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.

RockteMQ-AI commented on issue #4819:
URL: https://github.com/apache/rocketmq-dashboard/issues/4819#issuecomment-5770207100

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   This is a valid UI bug. The root cause is clear: `Ops.tsx` re-runs `fetchFailedMessage` on language change and unconditionally resets the NameServer selection via `setSelectedNamesrv(data.currentNamesrv)`, discarding any unsaved user selection.
   
   **Root Cause:** Same pattern as #4590 (BrokerCluster.tsx fix) — the setter should be guarded so it only falls back when the current selection no longer exists in the refreshed list.
   
   **Impact:** Low-medium — UX regression on the Ops page; no data loss, but operator workflow is disrupted.
   
   **Severity:** Medium
   
   An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
   
   ---
   *Automated evaluation by github-manager*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] Switching the display language resets an unsaved NameServer selection on the Ops page [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.

lizhimins commented on issue #4819:
URL: https://github.com/apache/rocketmq-dashboard/issues/4819#issuecomment-5928847574

   Resolved by #4818 (merged into rocketmq-studio as 00c5ce1b6).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org