You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/21 14:19:53 UTC

[GitHub] [superset] kgabryje commented on a change in pull request #18817: fix(sql Lab tabs): Empty SQL Lab tabs

kgabryje commented on a change in pull request #18817:
URL: https://github.com/apache/superset/pull/18817#discussion_r811174494



##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.jsx
##########
@@ -401,6 +409,19 @@ class TabbedSqlEditors extends React.PureComponent {
       );
     });
 
+    const emptyTab = (
+      <EditableTabs.TabPane
+        key={0}
+        data-key={0}
+        tab={<TabTitle>Add a New Tab</TabTitle>}

Review comment:
       ```suggestion
           tab={<TabTitle>{t('Add a New Tab')}</TabTitle>}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org