You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2023/03/06 09:46:35 UTC

[GitHub] [flink-connector-kafka] MartijnVisser commented on pull request #4: [FLINK-30996] Sync Kafka 1.17 commits from apache/flink repo to flink-connector-kafka

MartijnVisser commented on PR #4:
URL: https://github.com/apache/flink-connector-kafka/pull/4#issuecomment-1455805251

   > @MartijnVisser would you suggest me to double check anything else for us to confidently approve this?
   
   I think you've covered everything. We usually compared the commits to see that all code that needed to exist actually existed + the necesary LICENSE/NOTICE stuff. And of course CI needed to pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org