You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/18 10:40:50 UTC

[GitHub] [skywalking-client-js] Fine0830 opened a new pull request #10: Docs: Improve project readme

Fine0830 opened a new pull request #10:
URL: https://github.com/apache/skywalking-client-js/pull/10


   Write project usage, development document.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #10: Docs: Improve project readme

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #10:
URL: https://github.com/apache/skywalking-client-js/pull/10#discussion_r490959859



##########
File path: docs/README.md
##########
@@ -0,0 +1,133 @@
+Apache SkyWalking Client JS

Review comment:
       Is this Chinese translation? If so, please rename to `/README-CN.md`. And this should be linked from `README.md`
   
   Remind, usually, we don't maintain two language documents, of course, if you wish, you could.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-client-js] wu-sheng merged pull request #10: Docs: Improve project readme

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #10:
URL: https://github.com/apache/skywalking-client-js/pull/10


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-client-js] Fine0830 commented on a change in pull request #10: Docs: Improve project readme

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #10:
URL: https://github.com/apache/skywalking-client-js/pull/10#discussion_r491333838



##########
File path: docs/README.md
##########
@@ -0,0 +1,133 @@
+Apache SkyWalking Client JS

Review comment:
       Yes, it is. If so, I will delete Chinese document.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-client-js] Fine0830 commented on pull request #10: Docs: Improve project readme

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #10:
URL: https://github.com/apache/skywalking-client-js/pull/10#issuecomment-695185456


   Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org