You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/02/25 03:07:09 UTC
[GitHub] [incubator-uniffle] zuston opened a new issue, #661: [FEATURE] Introduce the general client conf for mr/spark
zuston opened a new issue, #661:
URL: https://github.com/apache/incubator-uniffle/issues/661
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### Describe the feature
Now in mr/spark client conf, we don't obey the rule of uniffle `configOptions`. It causes the some problems as follows
1. When introducing the client general conf, we have to write three times in `RssSparkConfig`/ `RssClientConfig` / `RssMRConfig`. Actually there is no need to leave dirty works for developers.
2. If when introducing a general method for MR/Spark and need to some configs from Rss client conf. In current implementation, we have to introduce extra class for method's params. If we having the general RssClientConf, it will benifit more.
### Motivation
_No response_
### Describe the solution
_No response_
### Additional context
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #661: [FEATURE] Introduce the general client conf for mr/spark
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #661:
URL: https://github.com/apache/incubator-uniffle/issues/661#issuecomment-1489892622
> @zuston would you like to work on this?
>
> I feel the pain when implementing stage recomputing for spark clients.
This issue is not of high priority. I'm curious about the pain you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #661: [FEATURE] Introduce the general client conf for mr/spark
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #661:
URL: https://github.com/apache/incubator-uniffle/issues/661#issuecomment-1445831096
I'm for this idea. `RssSparkConfig` and `RssMRConfig` should be subclass of `RssClientConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #661: [FEATURE] Introduce the general client conf for mr/spark
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #661:
URL: https://github.com/apache/incubator-uniffle/issues/661#issuecomment-1489864946
@zuston would you like to work on this?
I feel the pain when implementing stage recomputing for spark clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org