You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2024/07/31 18:13:57 UTC
[PR] RATIS-2129. Low replication performance because GrpcLogAppender is often blocked by RaftLog's readLock. [ratis]
szetszwo opened a new pull request, #1127:
URL: https://github.com/apache/ratis/pull/1127
See RATIS-2129
(Temporally targeting to the `release-3.1.0` branch. Will submit a pr for the master once this has passed all the tests.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2129. Low replication performance because of lock contention on RaftLog [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo closed pull request #1127: RATIS-2129. Low replication performance because of lock contention on RaftLog
URL: https://github.com/apache/ratis/pull/1127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2129. Low replication performance because of lock contention on RaftLog [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1127:
URL: https://github.com/apache/ratis/pull/1127#issuecomment-2318470856
Submitted https://github.com/apache/ratis/pull/1141 for the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2129. Low replication performance because of lock contention on RaftLog [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1127:
URL: https://github.com/apache/ratis/pull/1127#issuecomment-2329521149
Sure, let's close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2129. Low replication performance because GrpcLogAppender is often blocked by RaftLog's readLock. [ratis]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on PR #1127:
URL: https://github.com/apache/ratis/pull/1127#issuecomment-2296409630
Hi, @szetszwo
We have tested this pull request, the write throughput is improved by about 25%.
Before:

After:

We analyzed the flame graph and found that 15% of the Raftlog read locks had disappeared, which made acquiring raftlog locks faster in the write path, resulting in better write performance.This indicates that the write throughput improvement from this PR is still substantial.
<img width="1511" alt="image" src="https://github.com/user-attachments/assets/ff960461-b1d9-4d01-857c-2c5eacb98cf6">
<img width="1511" alt="image" src="https://github.com/user-attachments/assets/78b33fa2-cf3d-464c-8458-96fc08894695">
In addition, we found that UpdateCommitIndex also takes a lot of CPU in the latest optimized scenario. It should be beneficial to continue to optimize the locking logic here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2129. Low replication performance because GrpcLogAppender is often blocked by RaftLog's readLock. [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1127:
URL: https://github.com/apache/ratis/pull/1127#issuecomment-2297071049
@OneSizeFitsQuorum , thanks a lot for testing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2129. Low replication performance because of lock contention on RaftLog [ratis]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on PR #1127:
URL: https://github.com/apache/ratis/pull/1127#issuecomment-2327834631
Hi, @szetszwo , we can close this PR because the release-3.1.x will not contain this PR and we can include this work in the future 3.2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org