You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mnemonic.apache.org by yzz127 <gi...@git.apache.org> on 2017/10/01 22:38:48 UTC
[GitHub] incubator-mnemonic pull request #73: MNEMONIC-321 Implement Java method for ...
GitHub user yzz127 opened a pull request:
https://github.com/apache/incubator-mnemonic/pull/73
MNEMONIC-321 Implement Java method for durable object vectorization
This is one of the sub-tasks under MNEMONIC issue 307 durable object vectorization. This sub-task focuses on the implementation of the Java method for durable object vectorization.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yzz127/incubator-mnemonic master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-mnemonic/pull/73.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #73
----
commit 6be0417ba3657a8d36692f22b56c123b3dda07f1
Author: Yanhui Zhao <yz...@apache.org>
Date: 2017-10-01T22:20:19Z
MNEMONIC-321 Implement Java method for durable object vectorization
----
---
[GitHub] incubator-mnemonic pull request #73: MNEMONIC-321 Implement Java method for ...
Posted by bigdata-memory <gi...@git.apache.org>.
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/73#discussion_r142317858
--- Diff: mnemonic-computing-services/mnemonic-utilities-service/src/main/java/org/apache/mnemonic/service/computing/internal/PrintServiceImpl.java ---
@@ -50,6 +50,11 @@ public String getServiceId() {
return ret;
}
+ @Override
+ public long[] perform(String mode, ValueInfo[] valinfos, long dcHandler, long dcSize) {
+ return null;
--- End diff --
It is better to throw UnsupportedOperationException please,
---
[GitHub] incubator-mnemonic pull request #73: MNEMONIC-321 Implement Java method for ...
Posted by bigdata-memory <gi...@git.apache.org>.
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/73#discussion_r142317878
--- Diff: mnemonic-computing-services/mnemonic-utilities-service/src/main/java/org/apache/mnemonic/service/computing/internal/SortServiceImpl.java ---
@@ -54,6 +54,11 @@ public String getServiceId() {
return ret;
}
+ @Override
+ public long[] perform(String mode, ValueInfo[] valinfos, long dcHandler, long dcSize) {
+ return null;
--- End diff --
ditto. please
---
[GitHub] incubator-mnemonic pull request #73: MNEMONIC-321 Implement Java method for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-mnemonic/pull/73
---