You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Renan DelValle <re...@gmail.com> on 2018/01/18 17:45:32 UTC
Review Request 65222: GitHub Pull Request template to discourage
folks from making PRs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65222/
-----------------------------------------------------------
Review request for Aurora, Stephan Erb and Bill Farner.
Repository: aurora
Description
-------
Simple pull request template encouraging potential contributors to submit via ReviewBoard instead of opening up a PR on GitHub.
Normally I wouldn't want to add something to the repo that is platform specific, but given the fact that we have a lot of exposure on GitHub and that there's no way to disallow PRs, it might be a good idea to point potential contributors in the right direction from the get go.
Diffs
-----
.github/pull_request_template.md PRE-CREATION
Diff: https://reviews.apache.org/r/65222/diff/1/
Testing
-------
Text change only.
Thanks,
Renan DelValle
Re: Review Request 65222: GitHub Pull Request template to discourage
folks from making PRs
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65222/#review195739
-----------------------------------------------------------
Master (8a5dcac) is red with this patch.
./build-support/jenkins/build.sh
Pass 2: Analyzing classes (327 / 333) - 98% complete
Pass 2: Analyzing classes (328 / 333) - 98% complete
Pass 2: Analyzing classes (329 / 333) - 98% complete
Pass 2: Analyzing classes (330 / 333) - 99% complete
Pass 2: Analyzing classes (331 / 333) - 99% complete
Pass 2: Analyzing classes (332 / 333) - 99% complete
Pass 2: Analyzing classes (333 / 333) - 100% complete
Done with analysis
:test
org.apache.aurora.scheduler.discovery.CuratorSingletonServiceTest > testDefeatTransition FAILED
org.junit.runners.model.TestTimedOutException at CuratorSingletonServiceTest.java:165
org.apache.aurora.scheduler.discovery.CuratorSingletonServiceTest > testAbdicateTransition FAILED
org.apache.aurora.scheduler.app.ServiceGroupMonitor$MonitorException at CuratorSingletonServiceTest.java:119
Caused by: org.apache.curator.CuratorConnectionLossException at CuratorSingletonServiceTest.java:119
java.lang.AssertionError
I0118 18:20:08.993 [ShutdownHook, SchedulerMain] Stopping scheduler services.
1080 tests completed, 2 failed, 1 skipped
:test FAILED
:jacocoTestReport
Download https://repo1.maven.org/maven2/org/jacoco/org.jacoco.ant/0.7.8/org.jacoco.ant-0.7.8.pom
Download https://repo1.maven.org/maven2/org/jacoco/org.jacoco.ant/0.7.8/org.jacoco.ant-0.7.8.jar
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 21m 23s
45 actionable tasks: 36 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 18, 2018, 5:45 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65222/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 5:45 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Simple pull request template encouraging potential contributors to submit via ReviewBoard instead of opening up a PR on GitHub.
>
> Normally I wouldn't want to add something to the repo that is platform specific, but given the fact that we have a lot of exposure on GitHub and that there's no way to disallow PRs, it might be a good idea to point potential contributors in the right direction from the get go.
>
>
> Diffs
> -----
>
> .github/pull_request_template.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65222/diff/1/
>
>
> Testing
> -------
>
> Text change only.
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 65222: GitHub Pull Request template to discourage
folks from making PRs
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65222/#review195737
-----------------------------------------------------------
Ship it!
Great idea, thank you!
- Bill Farner
On Jan. 18, 2018, 9:45 a.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65222/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 9:45 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Simple pull request template encouraging potential contributors to submit via ReviewBoard instead of opening up a PR on GitHub.
>
> Normally I wouldn't want to add something to the repo that is platform specific, but given the fact that we have a lot of exposure on GitHub and that there's no way to disallow PRs, it might be a good idea to point potential contributors in the right direction from the get go.
>
>
> Diffs
> -----
>
> .github/pull_request_template.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65222/diff/1/
>
>
> Testing
> -------
>
> Text change only.
>
>
> Thanks,
>
> Renan DelValle
>
>