[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1147: DISPATCH-2033: Wait for both routers to connect to each other before …

[GitBox <gi...@apache.org>]

ChugR commented on a change in pull request #1147:
URL: https://github.com/apache/qpid-dispatch/pull/1147#discussion_r617889401



##########
File path: tests/system_tests_qdstat.py
##########
@@ -565,6 +565,7 @@ def setUpClass(cls):
         cls.router_2 = cls.tester.qdrouterd('test_router_2', config_2, wait=True)
         cls.router_1 = cls.tester.qdrouterd('test_router_1', config_1, wait=True)
         cls.router_1.wait_router_connected('R2')
+        cls.router_2.wait_router_connected('R1')

Review comment:
       That's a surprising fix. If 1 is connected to 2 then how can 2 not be connected to 1?
   Not to say that this is not a fix but maybe it's just the time spent executing the wait allows for some other thing to stabilize and not that 2 was not connected to 1.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org