[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #213: [YUNIKORN-434] Fix for scheduler crash when the queueName in pod spec doesn't contain DOT

[GitBox <gi...@apache.org>]

wilfred-s commented on pull request #213:
URL: https://github.com/apache/incubator-yunikorn-core/pull/213#issuecomment-703376485


   We should not crash but the analysis is I think not correct. The dot does not have to be part of the queue name in the pod spec. In this case without placement rules we should not be calling the `createSchedulingQueue()` at all.
   
   The scheduler does not have a placement rule specified based on the jira. That means there is no placement rule executed when the application is submitted. The queue in the pod spec must comply to one specific rule: it must exist and be fully qualified. If that is not the case we should reject the submission. We should never go and create a queue with the placement rules unless we make that behavioural change and document it.
   
   If we want to become more flexible we could run it by default through a placement rule that mimics that kind of behaviour but still does all the checks needed. That is why I filed [YUNIKORN-19](https://issues.apache.org/jira/browse/YUNIKORN-19). If no rules are given in the config run it through the `provided` rule with a create flag set to `false`. That will handle the queue not being qualified and check that the queue exists or not.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org