[jira] [Commented] (AVRO-3618) [Java] TestBinaryDecoder should check consistency with directBinaryDecoder

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604910#comment-17604910 ] 

ASF subversion and git services commented on AVRO-3618:
-------------------------------------------------------

Commit b26fbee245e39fd1aed19c16711126979b311691 in avro's branch refs/heads/master from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=b26fbee24 ]

AVRO-3618: Test both directBinaryDecoder and binaryDecoder (#1842)

* AVRO-3618: update binary decoder

* AVRO-3618: Adapt test with byte array for directBinaryDecoder

* AVRO-3618: update exceptions thrown by direct binary decoder

> [Java] TestBinaryDecoder should check consistency with directBinaryDecoder
> --------------------------------------------------------------------------
>
>                 Key: AVRO-3618
>                 URL: https://issues.apache.org/jira/browse/AVRO-3618
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Ryan Skraba
>            Assignee: Christophe Le Saec
>            Priority: Major
>              Labels: pull-request-available, starter
>             Fix For: 1.12.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The unit tests for TestBinaryDecoder were originally parameterized so that _every_ test verifies that {{*BinaryDecoder*}} and {{*DirectBinaryDecoder*}} show the same behaviour.
> In the meantime, some tests have been added or modified that only test BinaryDecoder (twice).  Where possible, this should be fixed so that both classes are checked and that their behaviour are the same.
> Notably: the {{testNegativeBytesLength}} throws a different exception when DirectBinaryEncoder is used.
> Please pay special attention around the tests deserializing invalid binary data: this might be an unrecoverable error for Avro that throws a runtime exception but shouldn't consume unnecessary resources or cause OutOfMemoryErrors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)