You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ryan Morgan <rm...@covalent.net> on 2000/07/13 05:13:26 UTC
[PATCH] config tree fixups
The following patch adds a global variable that allows modules to find
the root of the configuration tree. This very helpful to modules like
mod_info, since they can now look in the tree for configuration
directives rather than reparse the entire configuration file.
-Ryan
Re: [PATCH] config tree fixups
Posted by Greg Stein <gs...@lyra.org>.
On Wed, Jul 12, 2000 at 08:13:26PM -0700, Ryan Morgan wrote:
>
> The following patch adds a global variable that allows modules to find
> the root of the configuration tree. This very helpful to modules like
> mod_info, since they can now look in the tree for configuration
> directives rather than reparse the entire configuration file.
>...
> --- include/http_config.h 2000/06/03 16:27:03 1.29
> +++ include/http_config.h 2000/07/13 02:07:34
> @@ -366,6 +366,7 @@
> #ifdef CORE_PRIVATE
>
> extern API_VAR_EXPORT module *top_module;
> +extern API_VAR_EXPORT ap_directive_t *conftree;
>
> extern API_VAR_EXPORT module *ap_prelinked_modules[];
> extern API_VAR_EXPORT module *ap_preloaded_modules[];
That name should be namespace protected, and it shouldn't occur within the
CORE_PRIVATE area. I would suggest "ap_config_tree" for a name.
That might trim back the size of your patch (although creating more
semantically-close-to-their-purpose names such as "sub_tree" is a Good
Thing)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/