[GitHub] [arrow] westonpace commented on pull request #12601: ARROW-15901: [C++] Support Substrait projection with custom output field names

[GitBox <gi...@apache.org>]

westonpace commented on PR #12601:
URL: https://github.com/apache/arrow/pull/12601#issuecomment-1113895574

   Sorry for not noticing this originally.  Feel free to ping someone in the future after a few days.
   
   As for the PR, I think this is part of the solution but I think we also want to handle the case where the last node in the declaration is not a project node.  And we will want to have a plan in place for round-trip.  A simple solution would be to just add a project node onto the end (if one is not there already) but that would mean our plan wouldn't round-trip cleanly.
   
   Another approach could be to add a vector of names to `ConsumingSinkNodeOptions`.  The sink node could then take the output schema from its input, swap out the names, and pass that on to the consumer.  This should round-trip nicely.
   
   Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org