You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/26 06:15:43 UTC

[GitHub] [pulsar] merlimat commented on pull request #11788: Fix ConcurrentModificationException occurs when failPendingMessages

merlimat commented on pull request #11788:
URL: https://github.com/apache/pulsar/pull/11788#issuecomment-906126105


   > I am not sure this is the correct fix.
   > 
   > On one hand this change will fix the ConcurrentModificationException
   > But after reading #9650 it looks like the `pendingMessagesQueue` should be always accessed in a thread safe way.
   > Did you consider working on the loop in `failPendingMessages` and ensure thread safe access to `pendingMessagesQueue` ?
   
   I agree with @eolivelli, we should fix the concurrent access since most (obviously not all...) accesses to that queue are already protected by the ProducerImpl mutex.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org