[GitHub] [libcloud] macfreek commented on issue #1536: Inconsistency in specifying TTL in DNS records between example and tests

[GitBox <gi...@apache.org>]

macfreek commented on issue #1536:
URL: https://github.com/apache/libcloud/issues/1536#issuecomment-752648458


   Hi @Kami,
   
   Thanks for your feedback, and patience -- I'm aware that opening both an issue and a PR is a bit more work for you, and you probably have noted that I have a habit to changing the issue or PR while I dive deeper into the issue. I'll try to add a "WIP" (work in progress) tag if I'm not yet happy with the report or PR. You may want to delay your comments till I remove it, to save yourself some time. (And yes, I may sometimes change it even without that tag, once I discover more quirks.)
   
   I'll have a look if I can make a PR with the suggested change. It might require a significant number of changes in the drivers though.
   
   Also, I'll have to think how and when. How to ensure a (mostly) backwards compatible API, and when to make sure this ends up a minor or major release (not a bug fix release).
   
   A second question is if you would want to consider other (perhaps breaking) changes or clarifications.
   
   A few things that come to mind are:
   * Making the priority an attribute as well. (I'm in doubt. It's fairly common, in use for MX and SRV records, but next thing you know, you'll be adding port, weight, service, and protocol too).
   * Align the different `extra` field:
     * In particular zonomi adds a `prio` field, while all other drivers use `priority` as the field name. I prefer consistency here.
     * Align the use of `description` (Google), `comment` (Rackspace) and `notes` (Zerigo).
   * Clearly specify the use of trailing dots in both name and data that contain a FQDN. Right now, the name does seems to require a trailing dot (e.g. `www.example.com.`) A data field that requires a FQDN (e.g. MX, NS, PTR or CNAME) do require a trailing dot in DNS itself, but it seems that most API supported here insist that there MUST NOT be a trailing dot.
   * Be clear if/how IDN (international domain names) are supported. I kind of suspect that both name and data fields are expected to be punycode-encoded (e.g. `xn--bcher-kva.de.` instead of `bücher.de.`).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org