You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Johnny Cass <jo...@epiuse.com> on 2001/09/06 16:49:57 UTC

[Fwd: [Patch-Turbine-2]: TemplateSessionValidator.java]

Hi, 

Just a reminder that this bug is still present in Turbine 2.

Thanks.
- Johnny

Johnny Cass wrote:
> 
> Hi,
> 
> I think I might have found a possible bug in one of the
> SessionValidators of jakarta-turbine-2.
> 
> The way I see it, 'prev_template' needs to be saved to the user's
> temporary storage *before* the screen template is changed.
> 
> The 'template.invalidstate' parameter should probably also be added to
> TurbineResources.properties and / or TurbineResources.master files?
> 
> Thank you for your time.
> - Johnny.
> 
>   ------------------------------------------------------------------------
> Index: TemplateSessionValidator.java
> ===================================================================
> RCS file: /home/cvspublic/jakarta-turbine-2/src/java/org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 TemplateSessionValidator.java
> --- TemplateSessionValidator.java       2001/08/16 05:08:33     1.1.1.1
> +++ TemplateSessionValidator.java       2001/08/29 16:25:36
> @@ -125,11 +125,11 @@
>              {
>                  if (data.getTemplateInfo().getScreenTemplate() != null)
>                  {
> +                    data.getUser().setTemp( "prev_template",
> +                        data.getTemplateInfo().getScreenTemplate() );
>                      data.getTemplateInfo().setScreenTemplate(
>                          TurbineResources.getString(
>                          TurbineConstants.TEMPLATE_INVALID_STATE) );
> -                    data.getUser().setTemp( "prev_template",
> -                        data.getTemplateInfo().getScreenTemplate() );
>                  }
>                  else
>                  {
> 
>   ------------------------------------------------------------------------
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org