You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/01 22:19:49 UTC

[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #10214: Support alter database grammar

Liangda-w commented on a change in pull request #10214:
URL: https://github.com/apache/shardingsphere/pull/10214#discussion_r624573866



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/BaseRule.g4
##########
@@ -526,3 +526,51 @@ hashSubpartitionQuantity
 odciParameters
     : identifier
     ;
+
+databaseName
+    : identifier
+    ;
+
+locationName
+    : STRING_
+    ;
+
+fileName
+    : STRING_
+    ;
+
+asmFileName
+    : identifier
+    ;

Review comment:
       Hi @zhujunxxxxx maybe is STRING_ better?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org