You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/12 19:15:41 UTC

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #3048: xtensa/esp32: timer driver refactor

saramonteiro commented on a change in pull request #3048:
URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593392043



##########
File path: arch/xtensa/src/esp32/esp32_tim.c
##########
@@ -252,13 +248,10 @@ static void esp32_tim_modifyreg32(FAR struct esp32_tim_dev_s *dev,
  *
  ****************************************************************************/
 
-static int esp32_tim_start(FAR struct esp32_tim_dev_s *dev)
+static void esp32_tim_start(FAR struct esp32_tim_dev_s *dev)

Review comment:
       Please, note that this start is from lower half layer not from `esp32_tim.c`. The start function from lower half is still returning int value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org