You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/07 19:29:46 UTC
[GitHub] john-bodley opened a new pull request #5161: [migration] Adding
migration to remove empty in/not-in filters
john-bodley opened a new pull request #5161: [migration] Adding migration to remove empty in/not-in filters
URL: https://github.com/apache/incubator-superset/pull/5161
This PR adds a migration which removes instances of empty in/not-in filters. Note prior to adhoc-filters we speculate these were ignored whereas now they're present in the query (in the form of `1 != 1`).
It's unclear how these filters came to exist in this state but it seems prudent to simply remove them as with adhoc filters any slices with these invalid filters will result in no data.
to: @GabeLoins @michellethomas @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org