You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2021/06/10 19:55:08 UTC

[kudu-CR](branch-1.15.x) docs: use PNG instead of SVG for image 

Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17579


Change subject: docs: use PNG instead of SVG for image
......................................................................

docs: use PNG instead of SVG for image

The SVG resulted in a failed RAT check for the release, so this patch
updates to using a PNG, which is more common in our codebase anyway. It
also moves it into the /images folder in /docs.

Rendered version:
https://github.com/andrwng/kudu/blob/txns_docs/docs/design-docs/transactions.adoc

Change-Id: I6dff54eb4853e116b8da2ef2c604fe3de588bf5f
Reviewed-on: http://gerrit.cloudera.org:8080/17578
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
(cherry picked from commit 38f037e6622a4b3916418ed01186ec97ef136087)
---
D docs/design-docs/design-docs_transactions.svg
M docs/design-docs/transactions.adoc
A docs/images/design-docs_transactions.png
3 files changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/17579/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6dff54eb4853e116b8da2ef2c604fe3de588bf5f
Gerrit-Change-Number: 17579
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR](branch-1.15.x) docs: use PNG instead of SVG for image

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17579 )

Change subject: docs: use PNG instead of SVG for image
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dff54eb4853e116b8da2ef2c604fe3de588bf5f
Gerrit-Change-Number: 17579
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Jun 2021 20:01:30 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.15.x) docs: use PNG instead of SVG for image

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17579 )

Change subject: docs: use PNG instead of SVG for image
......................................................................

docs: use PNG instead of SVG for image

The SVG resulted in a failed RAT check for the release, so this patch
updates to using a PNG, which is more common in our codebase anyway. It
also moves it into the /images folder in /docs.

Rendered version:
https://github.com/andrwng/kudu/blob/txns_docs/docs/design-docs/transactions.adoc

Change-Id: I6dff54eb4853e116b8da2ef2c604fe3de588bf5f
Reviewed-on: http://gerrit.cloudera.org:8080/17578
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
(cherry picked from commit 38f037e6622a4b3916418ed01186ec97ef136087)
Reviewed-on: http://gerrit.cloudera.org:8080/17579
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
D docs/design-docs/design-docs_transactions.svg
M docs/design-docs/transactions.adoc
A docs/images/design-docs_transactions.png
3 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dff54eb4853e116b8da2ef2c604fe3de588bf5f
Gerrit-Change-Number: 17579
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)