You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/04/12 14:16:26 UTC

DO NOT REPLY [Bug 49095] New: org.apache.tomcat.util.net.AprEndpoint.unlockAccept does not wakeup accepts with deferred accept or BSD filters

https://issues.apache.org/bugzilla/show_bug.cgi?id=49095

           Summary: org.apache.tomcat.util.net.AprEndpoint.unlockAccept
                    does not wakeup accepts with deferred accept or BSD
                    filters
           Product: Tomcat 6
           Version: 6.0.26
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Connectors
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: rpluem@apache.org


Created an attachment (id=25266)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25266)
Patch to fix issue

org.apache.tomcat.util.net.AprEndpoint.unlockAccept does not wakeup accepts
with deferred accept or BSD filters. This is because it only connects to its
connector for causing the accept call to return. This is not enough in the case
of a deferred accept / BSD filters as the accept call only returns from the
kernel if data was sent / a HTTP request was sent. The attached patch fixes
that by sending and OPTIONS * in this case.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49095] org.apache.tomcat.util.net.AprEndpoint.unlockAccept does not wakeup accepts with deferred accept or BSD filters

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49095

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> 2010-06-07 01:11:05 EDT ---
Fixed in 6.0 in r952090 and will be in 6.0.27 onwards.



Note, that all the affected lines are guarded by if(deferAccept) clauses.
It is easy to remove that clause and extend this implementation of
unlockAccept() that sends a valid "OPTIONS" request upon other connector
implementations. Is it worth doing?


Regarding the 'BSD filters': apparently the documentation on them is here: [1],
[2]

[1] http://www.freebsd.org/cgi/man.cgi?query=accept_filter&sektion=9
[2] http://www.freebsd.org/cgi/man.cgi?query=setsockopt&sektion=2  (see
SO_ACCEPTFILTER)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49095] org.apache.tomcat.util.net.AprEndpoint.unlockAccept does not wakeup accepts with deferred accept or BSD filters

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49095

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25266|0                           |1
        is obsolete|                            |

--- Comment #2 from Konstantin Kolinko <kn...@gmail.com> 2010-06-02 14:11:48 EDT ---
Created an attachment (id=25510)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25510)
2010-06-02_tc6_bug49095.patch

Updated the tc6.0.x patch to explicitly specify the encoding used by the
Writer. That is r950682 of trunk.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49095] org.apache.tomcat.util.net.AprEndpoint.unlockAccept does not wakeup accepts with deferred accept or BSD filters

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49095

--- Comment #1 from Mark Thomas <ma...@apache.org> 2010-05-25 09:56:53 EDT ---
Fixed in trunk and proposed for 6.0.x.
Thanks for the patch.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org