You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by necosta <gi...@git.apache.org> on 2017/06/06 18:21:16 UTC
[GitHub] zeppelin pull request #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
GitHub user necosta opened a pull request:
https://github.com/apache/zeppelin/pull/2398
[ZEPPELIN-2622] Add Zeppelin Git info REST API
### What is this PR for?
Added a new REST API that provides more detailed info. on the exact source code Git commit Id that created the build. Useful to track down bugs and replicate issues.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Add more Git properties
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2622
### How should this be tested?
Build Zeppelin. Open http://localhost:8080/api/git
### Screenshots (if appropriate)
Expected output: {"status":"OK","message":"Zeppelin Git info","body":{"commitId":"4c2d295","timestamp":"2017-06-06 19:00:01"}}
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? Y (Done)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2398
----
commit 4c2d295c71d85b94f4ecf39edba9fe5c98a036de
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-06T18:00:01Z
[ZEPPELIN-2622] Add Zeppelin Git info REST API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Thanks guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2398
[ZEPPELIN-2622] Add Zeppelin Git info REST API
### What is this PR for?
Added a new REST API that provides more detailed info. on the exact source code Git commit Id that created the build. Useful to track down bugs and replicate issues.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Add more Git properties
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2622
### How should this be tested?
Build Zeppelin. Open http://localhost:8080/api/git
### Screenshots (if appropriate)
Expected output: {"status":"OK","message":"Zeppelin Git info","body":{"commitId":"4c2d295","timestamp":"2017-06-06 19:00:01"}}
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? Y (Done)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2398
----
commit 75795f1520cae28cfe7109198e9e758907008748
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-06T18:00:01Z
[ZEPPELIN-2622] Add Zeppelin Git info REST API
commit 9ff7d6067d7c9961a88c0bf5f9691c568ba26e4b
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-06T19:10:12Z
[ZEPPELIN-2622] Added missing license
commit 2d204555be899da15812e6872371bef6291b0265
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-09T15:42:43Z
[ZEPPELIN-2622] Merged version and git REST APIs
commit 426b1eac7d9f97b460fe15626c835d4ea46f99c8
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-11T12:18:27Z
[ZEPPELIN-2622] Minor adjustments
commit dc76a2439f0a4893ede631a13214ab032ba98f8a
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-11T19:52:47Z
[ZEPPELIN-2622] Keep 'About Zeppelin' window only displaying version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2398
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Ready for another look. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Merging if there's no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2398
[ZEPPELIN-2622] Add Zeppelin Git info REST API
### What is this PR for?
Added a new REST API that provides more detailed info. on the exact source code Git commit Id that created the build. Useful to track down bugs and replicate issues.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Add more Git properties
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2622
### How should this be tested?
Build Zeppelin. Open http://localhost:8080/api/git
### Screenshots (if appropriate)
Expected output: {"status":"OK","message":"Zeppelin Git info","body":{"commitId":"4c2d295","timestamp":"2017-06-06 19:00:01"}}
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? Y (Done)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2398
----
commit 75795f1520cae28cfe7109198e9e758907008748
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-06T18:00:01Z
[ZEPPELIN-2622] Add Zeppelin Git info REST API
commit 9ff7d6067d7c9961a88c0bf5f9691c568ba26e4b
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-06T19:10:12Z
[ZEPPELIN-2622] Added missing license
commit 2d204555be899da15812e6872371bef6291b0265
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-09T15:42:43Z
[ZEPPELIN-2622] Merged version and git REST APIs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Thanks @necosta for very useful improvement.
It's not a strong opinion, but how about make `api/version` return version and git hash instead of add new api endpoint `api/git`? I think commit hash and timestamp can be part of version information. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2398
Thanks for the feedback @Leemoonsoo. Yes, I was 50-50 on having a new API or reusing the "version" one. I'll go with your suggestion and refactor this later this week. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---