You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/06 07:45:18 UTC

[GitHub] [pulsar] nicoloboschi commented on a change in pull request #12439: [Issue 12271][Modernizer] Add Maven Modernizer plugin to pulsar-metadata module

nicoloboschi commented on a change in pull request #12439:
URL: https://github.com/apache/pulsar/pull/12439#discussion_r762763946



##########
File path: pulsar-metadata/pom.xml
##########
@@ -94,6 +94,23 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.gaul</groupId>
+        <artifactId>modernizer-maven-plugin</artifactId>
+        <version>${maven-modernizer-plugin.version}</version>
+        <configuration>

Review comment:
       is it better to set the configuration in the root POM and share it with all submodules
   
   cc @MarvinCai 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org