You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/22 08:20:13 UTC
[GitHub] [dubbo-go] JiaLiangoooo opened a new pull request #1006: Fix: registry simplified ignore user params
JiaLiangoooo opened a new pull request #1006:
URL: https://github.com/apache/dubbo-go/pull/1006
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Fix: registry simplified ignore user params
**Does this PR introduce a user-facing change?**:
需要在service加一个自定义参数，但是consul会默认simplified=true，会忽略自己的自定义参数.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo closed pull request #1006: Fix: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo closed pull request #1006:
URL: https://github.com/apache/dubbo-go/pull/1006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo commented on pull request #1006: Fix: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo commented on pull request #1006:
URL: https://github.com/apache/dubbo-go/pull/1006#issuecomment-774030471
https://github.com/apache/dubbo-go/issues/1044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on pull request #1006: Fix: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
cityiron commented on pull request #1006:
URL: https://github.com/apache/dubbo-go/pull/1006#issuecomment-774009379
Create your issue, make PR better to do, tks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1006: Fix: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1006:
URL: https://github.com/apache/dubbo-go/pull/1006#issuecomment-770715221
pls change the target branch to 1.5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo edited a comment on pull request #1006: Fix: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo edited a comment on pull request #1006:
URL: https://github.com/apache/dubbo-go/pull/1006#issuecomment-770131971
@zouyx 因为支持多registry注册. 而目前用户自定义参数与dubbo-go定义的参数耦合在一起. 如果在serviceConfig里面修改的话，会存在问题. 目前想到的有两个方案，请问还有其它的吗?
1. 可否在URL里面新增一个自定义param的参数，将用户自定义的与dubbo-go定义的参数分开
2. 将用户自定义的增加一个特殊的前缀，修改getParm方法里面的方法，但是这个会带来一个问题，用户自定义与dubbo-go定义的会不能区分. 需要将dubbo-go定义的参数维护起来，用户不能使用这些关键字.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo commented on pull request #1006: Fix: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo commented on pull request #1006:
URL: https://github.com/apache/dubbo-go/pull/1006#issuecomment-770131971
@zouyx 因为支持多registry注册. 而目前用户自定义参数与dubbo-go定义的参数耦合在一起. 如果在serviceConfig里面修改的话，会存在问题.
1. 可否在URL里面新增一个自定义param的参数，将用户自定义的与dubbo-go定义的参数分开
2. 将用户自定义的增加一个特殊的前缀，修改getParm方法里面的方法，但是这个会带来一个问题，用户自定义与dubbo-go定义的会不能区分. 需要将dubbo-go定义的参数维护起来，用户不能使用这些关键字.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org