You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "christopher james dollin (JIRA)" <ji...@apache.org> on 2012/11/26 12:22:59 UTC

[jira] [Commented] (JENA-354) running eyeball tests fails

    [ https://issues.apache.org/jira/browse/JENA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503735#comment-13503735 ] 

christopher james dollin commented on JENA-354:
-----------------------------------------------

Eyeball is no longer built with ant; it is built with maven. The documentation is out-of-date. 
                
> running eyeball tests fails
> ---------------------------
>
>                 Key: JENA-354
>                 URL: https://issues.apache.org/jira/browse/JENA-354
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Eyeball
>    Affects Versions: Jena 2.10.0
>            Reporter: Jos
>
> Building eyeball and running the tests fails.
> Eyeball was obtained with 
>  svn clone https://svn.apache.org/repos/asf/jena/Scratch/Eyeball/trunk/
> then these binary jars were put in the lib/ directory:
>  jena-core-2.7.4.jar
>  jena-iri-0.9.4.jar
>  jena-arq-2.9.4.jar
>  jena-core-2.7.4-tests.jar
> eyeball.jar was created by running 'ant'
> Then an attempt was made to run the tests with 'ant test' which resulted in:
>   BUILD FAILED
> /tmp/trunk/build.xml:146: /tmp/trunk/src-test does not exist.
> Creating the missing resulted in the command 'ant test' ending with
>  BUILD SUCCESSFUL
> but no tests were run.
> So src-test and it's content is missing from the repository.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Eyeball

Posted by Andy Seaborne <an...@apache.org>.
> I believe all the dependencies
> are apache-acceptable:
>
>        <groupId>junit</groupId>
>        <artifactId>junit</artifactId>
>
>        <groupId>org.slf4j</groupId>
>        <artifactId>slf4j-api</artifactId>
>
>        <groupId>org.apache.jena</groupId>
>        <artifactId>jena-core</artifactId>
>
>        <groupId>org.apache.jena</groupId>
>        <artifactId>jena-core</artifactId>
>
>        <groupId>org.apache.jena</groupId>
>        <artifactId>jena-arq</artifactId>
>
>        <groupId>org.slf4j</groupId>
>        <artifactId>slf4j-log4j12</artifactId>
>
>        <groupId>log4j</groupId>
>        <artifactId>log4j</artifactId>

All sane - Jena already uses all of those.

You'll need NOTICE and LICENSE files.

0/ For the source distribution.

1/ For a maven build, (same as 0) - The N&L in ARQ or TDB will do as a 
start.

2/ For a runnable jar, Eyeball is now reshipping other people's stuff so 
rolled up NOTICE & LICENSE are needed.

See jena-fuseki/dist for it's N&L files which arte difefren tto the N&L 
files in the directory jena-fuseki/ (the fuseki jar, no dependencies). 
And the assembly that pustthem into the combined jar
(assembly-dist.xml).

	Andy

(I'd delete build.xml myself).



Re: Eyeball

Posted by Chris Dollin <ch...@epimorphics.com>.
On Tuesday, November 27, 2012 04:20:53 PM Andy Seaborne wrote:
> On 26/11/12 15:20, Chris Dollin wrote:
> > I wrote re: JENA-354:
> >
> >> Eyeball is no longer built with ant; it is built with maven.
> >> The documentation is out-of-date.
> >
> > Talking of Eyeball [Jena's "RDF lint" application] ...
> >
> > Who would be interested in helping getting Eyeball into
> > a releasable state, rather than it languishing in Scratch?
> > Eyeball is a useful tool (by which I mean I know people
> > who use it) but there's no canonical source or jars for it
> > at the moment.
> 
> What needs to be done?

Clean the licencing (I haven't RATed yet). I believe all the dependencies
are apache-acceptable:

      <groupId>junit</groupId>
      <artifactId>junit</artifactId>

      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-api</artifactId>
      
      <groupId>org.apache.jena</groupId>
      <artifactId>jena-core</artifactId>
      
      <groupId>org.apache.jena</groupId>
      <artifactId>jena-core</artifactId>
      
      <groupId>org.apache.jena</groupId>
      <artifactId>jena-arq</artifactId>
      
      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-log4j12</artifactId>
      
      <groupId>log4j</groupId>
      <artifactId>log4j</artifactId>

Update the documentation. This could be anywhere between
"adjust to accomodate the recent changes made" and "rewrite".
I'm probably too close to both the code and the existing
documentation to make a judgement about how good it
is[n't].

A Maven maven should inspect the pom and make it sane. My
intention is to make easily available the Eyeball component
jars (for people building their own inspectors etc) and a
stand-alone all-in-one java-jarable "application" jar. I am
sufficiently a maven novice that I don't know if I'm doing that
right.

Replace the deleted RDB slot with an equivalent TDB slot, allowing
Eyeball to check (slowly, since it's not actually optimised for this)
models held in TDBs and not only models from files/URLs which
it currently loads into memory.

I think -- but may be wrong -- that this would be sufficient to make
a releasable Eyeball that would replace the "over there in SourceForge"
one that people are still using. It's also an opportunity for developers
to kick Eyeball's tyres and see if there are useful things it could be
doing in future development.

Chris

-- 
"It is seldom good news."      ~Crystal Ball~, /The Tough Guide to Fantasyland/

Epimorphics Ltd, http://www.epimorphics.com
Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT
Epimorphics Ltd. is a limited company registered in England (number 7016688)


Re: Eyeball

Posted by Andy Seaborne <an...@apache.org>.
On 26/11/12 15:20, Chris Dollin wrote:
> I wrote re: JENA-354:
>
>> Eyeball is no longer built with ant; it is built with maven.
>> The documentation is out-of-date.
>
> Talking of Eyeball [Jena's "RDF lint" application] ...
>
> Who would be interested in helping getting Eyeball into
> a releasable state, rather than it languishing in Scratch?
> Eyeball is a useful tool (by which I mean I know people
> who use it) but there's no canonical source or jars for it
> at the moment.

What needs to be done?

>
> If we can make a bridging release -- a tidied version [1] of
> the "current" functionality -- so that existing users have
> access to a maintained source, we'd be in a better position
> to develop it further.
>
> [I'm one of the original Jena developers,  although I haven't been active
>   for a while, and the developer of Eyeball.]
>
> Chris
>
> [1] EG, in Scratch, I stripped out the undocumented-and-unsupported
>      "repair/doctor" feature and the obsolete RDB support.
>

What's the legal status?

What does the RAT [*] report say? (clean is unlikely on test materials - 
it needs visual assessment)

	Andy

[*] http://creadur.apache.org/rat/

Eyeball

Posted by Chris Dollin <ch...@epimorphics.com>.
I wrote re: JENA-354:

> Eyeball is no longer built with ant; it is built with maven. 
> The documentation is out-of-date. 

Talking of Eyeball [Jena's "RDF lint" application] ...

Who would be interested in helping getting Eyeball into
a releasable state, rather than it languishing in Scratch?
Eyeball is a useful tool (by which I mean I know people
who use it) but there's no canonical source or jars for it 
at the moment.

If we can make a bridging release -- a tidied version [1] of
the "current" functionality -- so that existing users have
access to a maintained source, we'd be in a better position
to develop it further.

[I'm one of the original Jena developers,  although I haven't been active 
 for a while, and the developer of Eyeball.]

Chris

[1] EG, in Scratch, I stripped out the undocumented-and-unsupported
    "repair/doctor" feature and the obsolete RDB support.

-- 
"I know it was late, but Mountjoy never bothers,                /Archer's Goon/
 so long as it's the full two thousand words."

Epimorphics Ltd, http://www.epimorphics.com
Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT
Epimorphics Ltd. is a limited company registered in England (number 7016688)


Re: Re: (JENA-354) running eyeball tests fails

Posted by Chris Dollin <ch...@epimorphics.com>.
On Wednesday, November 28, 2012 01:45:58 PM Andy Seaborne wrote:

> 3rd option - just fix the documentation and close the JIRA.

That works, if the fix is just a cover note for the bigger job to be done
(incorporating all the changes recently made).

Chris

-- 
"The wizard seemed quite willing when I talked to him."  /Howl's Moving Castle/

Epimorphics Ltd, http://www.epimorphics.com
Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT
Epimorphics Ltd. is a limited company registered in England (number 7016688)


Re: (JENA-354) running eyeball tests fails

Posted by Andy Seaborne <an...@apache.org>.
On 28/11/12 09:22, Chris Dollin wrote:
> On Tuesday, November 27, 2012 04:18:09 PM Andy Seaborne wrote:
>> Chris - this JIRA is open.
>>
>> Is there work to do?
>
> Since I identify the problem as being that the documentation is
> not up to date I think there is work to be done. Is it appropriate to
> add a comment to the JIRA saying so or should a new JIRA be opened
> with this specific subject?
>
> Chris "jira.novice"
>

Your choice.

3rd option - just fix the documentation and close the JIRA.

	Andy

Re: Re: (JENA-354) running eyeball tests fails

Posted by Chris Dollin <ch...@epimorphics.com>.
On Tuesday, November 27, 2012 04:18:09 PM Andy Seaborne wrote:
> Chris - this JIRA is open.
> 
> Is there work to do?

Since I identify the problem as being that the documentation is 
not up to date I think there is work to be done. Is it appropriate to
add a comment to the JIRA saying so or should a new JIRA be opened
with this specific subject?

Chris "jira.novice"

-- 
"I know it was late, but Mountjoy never bothers,                /Archer's Goon/
 so long as it's the full two thousand words."

Epimorphics Ltd, http://www.epimorphics.com
Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT
Epimorphics Ltd. is a limited company registered in England (number 7016688)


Re: (JENA-354) running eyeball tests fails

Posted by Andy Seaborne <an...@apache.org>.
Chris - this JIRA is open.

Is there work to do?

If there is no work to do, could it be resolved then closed?

(ditto JENA-355)

	Andy