You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Joseph Bergmark <be...@apache.org> on 2010/08/02 22:28:56 UTC
Re: [IMPORTANT] About Big Commits
Hi Gurkan, I followed your directions and ran the tests and hit a few setup
issues and not matching results.
Setup issues:
1) Received errors about having tomcat.home defined in two places. I had it
in both my pom.xml and inside of jboss-test-harness.properties. Had to
comment out the second instance to avoid the error.
2) Had to set "org.jboss.testharness.runIntegrationTests=false" for the
standalone tests. Not sure if this was assumed, but wasn't directly
mentioned in the standalone section of the TCK_RUNNING.TXT file.
3) Had to add the user/password for tomcat. This is printed in the INFO
messages, so wasn't hard to find but isn't mentioned in the instructions.
4) My silly mistake, but had to start tomcat first. This does seem a bit
odd though as the standalone tests don't actually leverage tomcat do they?
I don't see any output in the catalina.log. Perhaps this is due to
org.jboss.testharness.api.TestLauncher setting?
Errors after resolving the above:
Failed tests:
testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest)
testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest)
Tests run: 574, Failures: 2, Errors: 0, Skipped: 0
I will happily update the instructions in SVN with the steps i missed if
those appear correct. Not sure about the two failing tests in my
environment that don't fail for you. Does anyone else see these?
Sincerely,
Joe
On Mon, Jul 26, 2010 at 4:38 AM, Gurkan Erdogdu <gu...@yahoo.com>wrote:
> I have committed changes. Now, all 574 tests have passed.
>
>
>
>
> ________________________________
> From: Gurkan Erdogdu <gu...@yahoo.com>
> To: dev@openwebbeans.apache.org
> Sent: Mon, July 26, 2010 11:16:44 AM
> Subject: Re: [IMPORTANT] About Big Commits
>
> Hi Eric;
>
> Needs some tweaking on EJB plugin to allow standalone test's EJB classes
> are
> correctly deployed. Iwill tinker it.
>
> Regards;
>
> --Gurkan
>
>
> ________________________________
> From: Eric Covener <co...@gmail.com>
> To: dev@openwebbeans.apache.org
> Sent: Sun, July 25, 2010 7:39:13 PM
> Subject: Re: [IMPORTANT] About Big Commits
>
> On Sat, Jul 24, 2010 at 3:15 PM, Gurkan Erdogdu <gu...@yahoo.com>
> wrote:
> >
> http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt
> >
> Thanks Gurkan -- I ran standalone and got these results (twice) :
> Tests run: 574, Failures: 10, Errors: 0, Skipped: 0, Time elapsed:
> 42.527 sec <<< FAILURE!
>
> Results :
>
> Failed tests:
>
>
> testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest)
>
>
>
>
> testRemoteInterfacesAreNotInAPITypes(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest)
>
>
>
>
> testBeanTypesAreLocalInterfacesWithoutWildcardTypesOrTypeVariablesWithSuperInterfaces(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest)
>
>
>
>
> testNewBeanHasNoBeanELName(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>
>
>
> testNewBeanHasNoStereotypes(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>
>
>
> testNewBeanHasNoObservers(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>
>
>
> testForEachEnterpriseBeanANewBeanExists(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>
>
>
> testNewBeanIsHasOnlyNewBinding(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>
>
>
> testNewBeanIsDependentScoped(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>
>
>
> testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest)
>
>
>
>
> Is the current expectation that both web and standalone run 100%
> clean, with perhaps some timing issues that cause transient failures?
>
> I was surprised to see EJB definition tests in the standalone suite --
> do you test against a tomcat+openejb that has the integration applied?
> I don't think we could figure out "local interfaces only" without
> that (looking at testcase name only of one of the above)
>
>
> --
> Eric Covener
> covener@gmail.com
>
>
RE: [IMPORTANT] About Big Commits
Posted by Jacquelle Leggett <jd...@hotmail.com>.
I experienced similar setup issues when attempting to run the TCK.
> Date: Mon, 2 Aug 2010 16:28:56 -0400
> Subject: Re: [IMPORTANT] About Big Commits
> From: bergmark@apache.org
> To: dev@openwebbeans.apache.org
>
> Hi Gurkan, I followed your directions and ran the tests and hit a few setup
> issues and not matching results.
>
> Setup issues:
> 1) Received errors about having tomcat.home defined in two places. I had it
> in both my pom.xml and inside of jboss-test-harness.properties. Had to
> comment out the second instance to avoid the error.
> 2) Had to set "org.jboss.testharness.runIntegrationTests=false" for the
> standalone tests. Not sure if this was assumed, but wasn't directly
> mentioned in the standalone section of the TCK_RUNNING.TXT file.
> 3) Had to add the user/password for tomcat. This is printed in the INFO
> messages, so wasn't hard to find but isn't mentioned in the instructions.
> 4) My silly mistake, but had to start tomcat first. This does seem a bit
> odd though as the standalone tests don't actually leverage tomcat do they?
> I don't see any output in the catalina.log. Perhaps this is due to
> org.jboss.testharness.api.TestLauncher setting?
>
> Errors after resolving the above:
>
> Failed tests:
>
> testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest)
>
> testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest)
>
> Tests run: 574, Failures: 2, Errors: 0, Skipped: 0
>
> I will happily update the instructions in SVN with the steps i missed if
> those appear correct. Not sure about the two failing tests in my
> environment that don't fail for you. Does anyone else see these?
>
> Sincerely,
>
> Joe
>
>
>
> On Mon, Jul 26, 2010 at 4:38 AM, Gurkan Erdogdu <gu...@yahoo.com>wrote:
>
> > I have committed changes. Now, all 574 tests have passed.
> >
> >
> >
> >
> > ________________________________
> > From: Gurkan Erdogdu <gu...@yahoo.com>
> > To: dev@openwebbeans.apache.org
> > Sent: Mon, July 26, 2010 11:16:44 AM
> > Subject: Re: [IMPORTANT] About Big Commits
> >
> > Hi Eric;
> >
> > Needs some tweaking on EJB plugin to allow standalone test's EJB classes
> > are
> > correctly deployed. Iwill tinker it.
> >
> > Regards;
> >
> > --Gurkan
> >
> >
> > ________________________________
> > From: Eric Covener <co...@gmail.com>
> > To: dev@openwebbeans.apache.org
> > Sent: Sun, July 25, 2010 7:39:13 PM
> > Subject: Re: [IMPORTANT] About Big Commits
> >
> > On Sat, Jul 24, 2010 at 3:15 PM, Gurkan Erdogdu <gu...@yahoo.com>
> > wrote:
> > >
> > http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt
> > >
> > Thanks Gurkan -- I ran standalone and got these results (twice) :
> > Tests run: 574, Failures: 10, Errors: 0, Skipped: 0, Time elapsed:
> > 42.527 sec <<< FAILURE!
> >
> > Results :
> >
> > Failed tests:
> >
> >
> > testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest)
> >
> >
> >
> >
> > testRemoteInterfacesAreNotInAPITypes(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest)
> >
> >
> >
> >
> > testBeanTypesAreLocalInterfacesWithoutWildcardTypesOrTypeVariablesWithSuperInterfaces(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest)
> >
> >
> >
> >
> > testNewBeanHasNoBeanELName(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
> >
> >
> >
> >
> > testNewBeanHasNoStereotypes(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
> >
> >
> >
> >
> > testNewBeanHasNoObservers(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
> >
> >
> >
> >
> > testForEachEnterpriseBeanANewBeanExists(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
> >
> >
> >
> >
> > testNewBeanIsHasOnlyNewBinding(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
> >
> >
> >
> >
> > testNewBeanIsDependentScoped(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
> >
> >
> >
> >
> > testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest)
> >
> >
> >
> >
> > Is the current expectation that both web and standalone run 100%
> > clean, with perhaps some timing issues that cause transient failures?
> >
> > I was surprised to see EJB definition tests in the standalone suite --
> > do you test against a tomcat+openejb that has the integration applied?
> > I don't think we could figure out "local interfaces only" without
> > that (looking at testcase name only of one of the above)
> >
> >
> > --
> > Eric Covener
> > covener@gmail.com
> >
> >
Re: [IMPORTANT] About Big Commits
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
>>>I will re-run tests and look.
Tests are succesfully passed,
SimpleBeanLifecycleTest,DisposalMethodDefinitionTest
--Gurkan
________________________________
From: Gurkan Erdogdu <gu...@yahoo.com>
To: dev@openwebbeans.apache.org
Sent: Tue, August 3, 2010 9:21:01 AM
Subject: Re: [IMPORTANT] About Big Commits
>>>I will happily update the instructions in SVN with the steps i missed if
>>>those appear correct.
Thanks Joe, please update the documentation, your observations are correct!
>>>Not sure about the two failing tests in my
>>>>environment that don't fail for you. Does anyone else see these?
I will re-run tests and look.
4)....
For standalone tests, Tomcat is not needed. It boot OpenEJB and running tests
using StandAloneContainerImpl.
Regards;
--Gurkan
________________________________
From: Joseph Bergmark <be...@apache.org>
To: dev@openwebbeans.apache.org
Sent: Mon, August 2, 2010 11:28:56 PM
Subject: Re: [IMPORTANT] About Big Commits
Hi Gurkan, I followed your directions and ran the tests and hit a few setup
issues and not matching results.
Setup issues:
1) Received errors about having tomcat.home defined in two places. I had it
in both my pom.xml and inside of jboss-test-harness.properties. Had to
comment out the second instance to avoid the error.
2) Had to set "org.jboss.testharness.runIntegrationTests=false" for the
standalone tests. Not sure if this was assumed, but wasn't directly
mentioned in the standalone section of the TCK_RUNNING.TXT file.
3) Had to add the user/password for tomcat. This is printed in the INFO
messages, so wasn't hard to find but isn't mentioned in the instructions.
4) My silly mistake, but had to start tomcat first. This does seem a bit
odd though as the standalone tests don't actually leverage tomcat do they?
I don't see any output in the catalina.log. Perhaps this is due to
org.jboss.testharness.api.TestLauncher setting?
Errors after resolving the above:
Failed tests:
testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest)
testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest)
Tests run: 574, Failures: 2, Errors: 0, Skipped: 0
I will happily update the instructions in SVN with the steps i missed if
those appear correct. Not sure about the two failing tests in my
environment that don't fail for you. Does anyone else see these?
Sincerely,
Joe
On Mon, Jul 26, 2010 at 4:38 AM, Gurkan Erdogdu <gu...@yahoo.com>wrote:
> I have committed changes. Now, all 574 tests have passed.
>
>
>
>
> ________________________________
> From: Gurkan Erdogdu <gu...@yahoo.com>
> To: dev@openwebbeans.apache.org
> Sent: Mon, July 26, 2010 11:16:44 AM
> Subject: Re: [IMPORTANT] About Big Commits
>
> Hi Eric;
>
> Needs some tweaking on EJB plugin to allow standalone test's EJB classes
> are
> correctly deployed. Iwill tinker it.
>
> Regards;
>
> --Gurkan
>
>
> ________________________________
> From: Eric Covener <co...@gmail.com>
> To: dev@openwebbeans.apache.org
> Sent: Sun, July 25, 2010 7:39:13 PM
> Subject: Re: [IMPORTANT] About Big Commits
>
> On Sat, Jul 24, 2010 at 3:15 PM, Gurkan Erdogdu <gu...@yahoo.com>
> wrote:
> >
> http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt
> >
> Thanks Gurkan -- I ran standalone and got these results (twice) :
> Tests run: 574, Failures: 10, Errors: 0, Skipped: 0, Time elapsed:
> 42.527 sec <<< FAILURE!
>
> Results :
>
> Failed tests:
>
>
>testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest)
>
>)
>
>
>
>
>testRemoteInterfacesAreNotInAPITypes(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest)
>
>)
>
>
>
>
>testBeanTypesAreLocalInterfacesWithoutWildcardTypesOrTypeVariablesWithSuperInterfaces(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest)
>
>)
>
>
>
>
>testNewBeanHasNoBeanELName(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>)
>
>
>
>
>testNewBeanHasNoStereotypes(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>)
>
>
>
>
>testNewBeanHasNoObservers(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>)
>
>
>
>
>testForEachEnterpriseBeanANewBeanExists(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>)
>
>
>
>
>testNewBeanIsHasOnlyNewBinding(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>)
>
>
>
>
>testNewBeanIsDependentScoped(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>
>)
>
>
>
>
>testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest)
>
>)
>
>
>
>
> Is the current expectation that both web and standalone run 100%
> clean, with perhaps some timing issues that cause transient failures?
>
> I was surprised to see EJB definition tests in the standalone suite --
> do you test against a tomcat+openejb that has the integration applied?
> I don't think we could figure out "local interfaces only" without
> that (looking at testcase name only of one of the above)
>
>
> --
> Eric Covener
> covener@gmail.com
>
>
Re: [IMPORTANT] About Big Commits
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
>>>I will happily update the instructions in SVN with the steps i missed if
>>>those appear correct.
Thanks Joe, please update the documentation, your observations are correct!
>>>Not sure about the two failing tests in my
>>>>environment that don't fail for you. Does anyone else see these?
I will re-run tests and look.
4)....
For standalone tests, Tomcat is not needed. It boot OpenEJB and running tests
using StandAloneContainerImpl.
Regards;
--Gurkan
________________________________
From: Joseph Bergmark <be...@apache.org>
To: dev@openwebbeans.apache.org
Sent: Mon, August 2, 2010 11:28:56 PM
Subject: Re: [IMPORTANT] About Big Commits
Hi Gurkan, I followed your directions and ran the tests and hit a few setup
issues and not matching results.
Setup issues:
1) Received errors about having tomcat.home defined in two places. I had it
in both my pom.xml and inside of jboss-test-harness.properties. Had to
comment out the second instance to avoid the error.
2) Had to set "org.jboss.testharness.runIntegrationTests=false" for the
standalone tests. Not sure if this was assumed, but wasn't directly
mentioned in the standalone section of the TCK_RUNNING.TXT file.
3) Had to add the user/password for tomcat. This is printed in the INFO
messages, so wasn't hard to find but isn't mentioned in the instructions.
4) My silly mistake, but had to start tomcat first. This does seem a bit
odd though as the standalone tests don't actually leverage tomcat do they?
I don't see any output in the catalina.log. Perhaps this is due to
org.jboss.testharness.api.TestLauncher setting?
Errors after resolving the above:
Failed tests:
testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest)
testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest)
Tests run: 574, Failures: 2, Errors: 0, Skipped: 0
I will happily update the instructions in SVN with the steps i missed if
those appear correct. Not sure about the two failing tests in my
environment that don't fail for you. Does anyone else see these?
Sincerely,
Joe
On Mon, Jul 26, 2010 at 4:38 AM, Gurkan Erdogdu <gu...@yahoo.com>wrote:
> I have committed changes. Now, all 574 tests have passed.
>
>
>
>
> ________________________________
> From: Gurkan Erdogdu <gu...@yahoo.com>
> To: dev@openwebbeans.apache.org
> Sent: Mon, July 26, 2010 11:16:44 AM
> Subject: Re: [IMPORTANT] About Big Commits
>
> Hi Eric;
>
> Needs some tweaking on EJB plugin to allow standalone test's EJB classes
> are
> correctly deployed. Iwill tinker it.
>
> Regards;
>
> --Gurkan
>
>
> ________________________________
> From: Eric Covener <co...@gmail.com>
> To: dev@openwebbeans.apache.org
> Sent: Sun, July 25, 2010 7:39:13 PM
> Subject: Re: [IMPORTANT] About Big Commits
>
> On Sat, Jul 24, 2010 at 3:15 PM, Gurkan Erdogdu <gu...@yahoo.com>
> wrote:
> >
> http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt
> >
> Thanks Gurkan -- I ran standalone and got these results (twice) :
> Tests run: 574, Failures: 10, Errors: 0, Skipped: 0, Time elapsed:
> 42.527 sec <<< FAILURE!
>
> Results :
>
> Failed tests:
>
>
>testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest)
>)
>
>
>
>
>testRemoteInterfacesAreNotInAPITypes(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest)
>)
>
>
>
>
>testBeanTypesAreLocalInterfacesWithoutWildcardTypesOrTypeVariablesWithSuperInterfaces(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest)
>)
>
>
>
>
>testNewBeanHasNoBeanELName(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>)
>
>
>
>
>testNewBeanHasNoStereotypes(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>)
>
>
>
>
>testNewBeanHasNoObservers(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>)
>
>
>
>
>testForEachEnterpriseBeanANewBeanExists(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>)
>
>
>
>
>testNewBeanIsHasOnlyNewBinding(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>)
>
>
>
>
>testNewBeanIsDependentScoped(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest)
>)
>
>
>
>
>testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest)
>)
>
>
>
>
> Is the current expectation that both web and standalone run 100%
> clean, with perhaps some timing issues that cause transient failures?
>
> I was surprised to see EJB definition tests in the standalone suite --
> do you test against a tomcat+openejb that has the integration applied?
> I don't think we could figure out "local interfaces only" without
> that (looking at testcase name only of one of the above)
>
>
> --
> Eric Covener
> covener@gmail.com
>
>